Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update adapter dependencies in Gemspec #1370

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Update adapter dependencies in Gemspec #1370

merged 1 commit into from
Jan 6, 2022

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Jan 6, 2022 •
edited
Loading

Description

Adapters v2 have hard dependencies, hence can't be used with Faraday v1
Fixes #1368

@iMacTia
Update adapter dependencies in Gemspec
5e1aa13 
Adapters v2 have hard dependencies, hence can't be used with Faraday v1
@iMacTia iMacTia self-assigned this Jan 6, 2022
olleolleolle
olleolleolle approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@iMacTia iMacTia merged commit c65d3be into 1.x Jan 6, 2022
@iMacTia iMacTia deleted the fix-adapter-dependencies branch January 6, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees

@iMacTia iMacTia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iMacTia @olleolleolle