Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would like to introduce default value for
exc
indef initialize
forFaraday::Error
.In some cases it is difficult to find the reason on a first spot when doing
raise Faraday::ConnectionFailed
because it raisesArgumentError
. In other cases likeraise Faraday::TimeoutError
it works becauseFaraday::TimeoutError
sets default value orexc
.Link to related issues if any. (As
Fixes #XXX
) - there was no related issue.I found out that someone has been asking why this is happening on Stackoverflow, I spent some time today looking for an answer for myself.
From my perspective introducing default value does not break anything and simplify codebase.
Todos
List any remaining work that needs to be done, i.e:
Additional Notes
Optional section
Stackoverflow: https://stackoverflow.com/questions/59176256/unexpected-behaviour-with-faradayconnectionfailed/70427415#70427415