Remove net-http adapter and update docs #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt tests to work without net_http adapter. Switch `Faraday.default_adapter` to `:test`. Update UPGRADING.md and README.md
| * If you're relying on `Faraday.default_adapter` (e.g. if you use `Faraday.get` or other verb class methods, or not | ||
| specifying an adapter in your connection initializer), then you'll now need to set it yourself. It previously | ||
| defaulted to `:net_http`, but it now defaults to `:test`. | ||
|
|
There was a problem hiding this comment.
Perhaps this section could have a pasteable example of doing what the text says?
Suggested change
| Faraday.default_adapter = :net_http | |
There was a problem hiding this comment.
(Well, and some "you could do this" text.)
There was a problem hiding this comment.
I didn't know you could have multi-line code snippets inside list items!!
There was a problem hiding this comment.
Every day is a school day!
| @@ -628,9 +644,16 @@ | |||
| describe 'request params' do | |||
| context 'with simple url' do | |||
| let(:url) { 'http://example.com' } | |||
| let!(:stubbed) { stub_request(:get, 'http://example.com?a=a&p=3') } | |||
| let(:stubs) { Faraday::Adapter::Test::Stubs.new } | |||
olleolleolle
approved these changes
Oct 25, 2021
| * If you're relying on `Faraday.default_adapter` (e.g. if you use `Faraday.get` or other verb class methods, or not | ||
| specifying an adapter in your connection initializer), then you'll now need to set it yourself. It previously | ||
| defaulted to `:net_http`, but it now defaults to `:test`. | ||
|
|
There was a problem hiding this comment.
(Well, and some "you could do this" text.)
olleolleolle
approved these changes
Oct 25, 2021
| * If you're relying on `Faraday.default_adapter` (e.g. if you use `Faraday.get` or other verb class methods, or not | ||
| specifying an adapter in your connection initializer), then you'll now need to set it yourself. It previously | ||
| defaulted to `:net_http`, but it now defaults to `:test`. | ||
|
|
There was a problem hiding this comment.
Every day is a school day!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Faraday.default_adapterto:test.UPGRADING.mdandREADME.mdTodos
List any remaining work that needs to be done, i.e: