Improve request info in exceptions raised by RaiseError Middleware #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
approved these changes
Oct 16, 2021
There was a problem hiding this comment.
Hi @willianzocolau and thanks for fixing this!
I just want to point out that this PR will be merged on the main branch, and that currently contains the code that will go in the next major release (v2.0).
If you'd like to have this change released for Faraday v1 as well, then you'll need open another PR against the 1.x branch. This is absolutely not a requirement though, so feel free to ignore if you're planning to use v2.0 anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
Link to related issues if any. (As
fixes #XXX)Fixes #1249
Add URI object with the url requested and fix query string params. In test adapter, the params already was treated which means the specs was biased. With default adapter, the params problem occurred as described in Issue #1249.
Todos
List any remaining work that needs to be done, i.e:
Additional Notes
Optional section