Retry middleware should handle string exception class name consistently #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Thank you @jrochkind, code changes look good!
We just need to make CI passing and then LGTM 💯 🎉
…ass name consistently Closes lostisland#1330
jrochkind
force-pushed
the
retry_exceptions_option_string
branch
from
cfb2b37
to
270f1bf
Compare
|
Thanks! I believe I will have made rubocop happier now. |
jrochkind
added a commit
to jrochkind/faraday
that referenced
this pull request
Dec 20, 2021
…ass name consistently (lostisland#1334)
jrochkind
added a commit
to jrochkind/faraday
that referenced
this pull request
Dec 20, 2021
…ass name consistently (lostisland#1334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1330