Backport authorization procs to 1.x branch

[jarl-dk]

Description

This is a backport of authorization using Procs. It is a simple cherry-pick from main branch.

(cherry picked from commit fe600c7)

Todos

List any remaining work that needs to be done, i.e:

• Tests
• Rubocop
• Documentation

Additional Notes

This is a backport of authorization using Procs. It is a simple cherry-pick from main branch.
(cherry picked from commit fe600c7)

[olleolleolle]

@jarl-dk Thanks for taking a look at this.

A blocking issue with this cherry-pick is that it takes the step of removing the feature from the 1.x release series, which we only want to fully remove in the 2.x, which is brewing.

[jarl-dk]

@olleolleolle : Yes, I just realised this myself. Thanks. I'll see if I can make a backward compatible fixup (selective cherry-pick).

[jarl-dk]

The PR does contains some bloat code (if just reaching for Proc support). But my aim has been minimal code diff to v1.7.1 and as close as possible to fe600c72adc79180ad7e545191edd5dd2fe61990.

[iMacTia]

Thank you @jarl-dk, indeed I can see the extra code for basic auth support in the generic Authorization middleware.
I'm happy to clean up myself after this PR if you don't have the time, but I'd really like to see the new tests ported as well and the existing ones still passing before merging this.
There also seems to be a small issue with linting that will need to be fixed before merging.

[jarl-dk]

I'll give it a shot more...

[jarl-dk]

I have updated the PR to not remove any tests and just add the test regarding Proc.
@iMacTia : I'll leave the cleanup to you as it can be cleaned up in many different ways.

[iMacTia]

This is good enough, thanks @jarl-dk, I'll take over from here for the cleanup 👍