Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI : Can we drop "gem install bundler"? #1268

Closed
olleolleolle opened this issue Apr 14, 2021 · 3 comments · Fixed by #1297
Closed

CI : Can we drop "gem install bundler"? #1268

olleolleolle opened this issue Apr 14, 2021 · 3 comments · Fixed by #1297

Comments

@olleolleolle
Copy link
Member

olleolleolle commented Apr 14, 2021 •
edited
Loading

Basic Info

  • Faraday Version: CI
  • Ruby Version: this needs only happen for non-bundler-having Rubies

Issue description

In CI, are we wasting time on "install bundler"?
@iMacTia
Copy link
Member

iMacTia commented Apr 15, 2021

Happy to try and remove it as it's now bundled with Ruby, but this may cause issues with older Rubies (e.g. 2.4)

@olleolleolle
Copy link
Member Author

olleolleolle commented Apr 15, 2021 •
edited
Loading

Guessing: Since we have shell access, we could check either the running ruby -v OR use the matrix.version (CI YAML config value).

I am thinking "Only install a bundler if one does not exist."

@olleolleolle olleolleolle linked a pull request Aug 1, 2021 that will close this issue
Begin v2 release #1297
Merged
@olleolleolle
Copy link
Member Author

This was fixed in 6333b73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Begin v2 release lostisland/faraday
2 participants
@olleolleolle @iMacTia