Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ruby 3.0 to CI Matrix #1226

Merged
merged 5 commits into from
Dec 31, 2020
Merged

Adds Ruby 3.0 to CI Matrix #1226

merged 5 commits into from
Dec 31, 2020

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Dec 29, 2020

Description

Adds Ruby 3.0 to CI Matrix

Additional Notes

  • Should we keep Ruby head as experimental for future Ruby releases?

@olleolleolle
Copy link
Member

Timeouts are reported in a wonky way: on 3.0

https://github.com/lostisland/faraday/pull/1226/checks?check_run_id=1622851358#step:6:4461

@iMacTia
Copy link
Member Author

iMacTia commented Dec 31, 2020

@olleolleolle problem with Net::HTTP::Persistent timeouts it fixed 🙌
What do you think about keeping the ruby-head in the matrix? Is it still useful now that we added 3.0?

@olleolleolle
Copy link
Member

Oh, I think we can throw it out for the time being. Useful trick to have when big changes coming ahead. But not for all days.

Great news!

@iMacTia
Copy link
Member Author

iMacTia commented Dec 31, 2020

Thanks, makes sense.
Also, I just realised you already identified and attempted to fix this issue in #1154 !
In this branch, I raise a Faraday::Timeout exception to keep it consistent with the older behaviour, but does that mean we can now support Net::HTTP::Persistent also for older rubies 🤔?

So at the moment, we can see all tests are passing, but v4.0 is used only for Ruby 3.0 (see Gemfile)
I'll update the Gemfile to allow v4.0 also for lower rubies and give it a try 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants