Move out Net::HTTP adapter #1222
Conversation
The Net::HTTP adapter is extracted into its own gem. The idea behind this change is to create an ecosystem of different packages that you can use with Faraday, so that Faraday doesn’t have to ship with the packages itself. For now all the Net::HTTP tests are still in place to verify that everything is working correctly.
|
Just waiting for lostisland/faraday-net_http#2 to be merged to sync the 2 repos up again, then bump the |
faraday.gemspec
Outdated
| @@ -15,6 +15,7 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.required_ruby_version = '>= 2.4' | |||
|
|
|||
| spec.add_dependency 'faraday-net_http', '~> 0.0.6' | |||
There was a problem hiding this comment.
Hm, perhaps we should start it at 1.0?
There was a problem hiding this comment.
Like, the code is what we use in this repo.
There was a problem hiding this comment.
Yes I have already bumped faraday-net_http version to 1.0, BUT I realised @JanDintel is the only owner of the gem in Rubygems at the moment! So I can't publish it right now.
@JanDintel could you please add me and @olleolleolle as owners as well so we can publish new versions?
There was a problem hiding this comment.
@iMacTia and @olleolleolle I've added you as owners to the gem! You should have full permission to publish a new version.
@iMacTia I noticed that you still need to set-up MFA on Rubygems though :)
There was a problem hiding this comment.
@JanDintel thank you! Will release it now then, thanks a lot for all the work 🎉
@iMacTia I noticed that you still need to set-up MFA on Rubygems though :)
Yes, that's a looooooong story: rubygems/rubygems.org#2500
|
It's done! Massive thanks to @JanDintel for doing the bulk of the work 🎉 |
|
This causes a circular dependency issue.
|
Description
Removes Net::HTTP adapter from Faraday codebase and adds it as a dependency instead.
Replaces #1195
Additional Notes
This change should be completely backwards-compatible.
The dependency should be removed in Faraday v2.0