Fixed several issues reported by gosec

Author: looterz

api.go

@@ -62,11 +62,17 @@ func StartAPIServer(config *Config,
 
 	router.GET("/blockcache/personal", func(c *gin.Context) {
 		filePath := filepath.FromSlash("sources/personal.list")
-		f, err := os.OpenFile(filePath, os.O_APPEND|os.O_CREATE|os.O_RDONLY, 0644)
+		f, err := os.OpenFile(filePath, os.O_APPEND|os.O_CREATE|os.O_RDONLY, 0600)
 		if err != nil {
 			logger.Critical(err)
 		}
-		defer f.Close()
+
+		defer func() {
+			if err := f.Close(); err != nil {
+				logger.Criticalf("Error closing file: %s\n", err)
+			}
+		}()
+
 		personalBlockList := []string{}
 
 		scanner := bufio.NewScanner(f)
@@ -79,11 +85,16 @@ func StartAPIServer(config *Config,
 
 	router.GET("/blockcache/set/:key", func(c *gin.Context) {
 		filePath := filepath.FromSlash("sources/personal.list")
-		f, err := os.OpenFile(filePath, os.O_APPEND|os.O_CREATE|os.O_RDWR, 0644)
+		f, err := os.OpenFile(filePath, os.O_APPEND|os.O_CREATE|os.O_RDWR, 0600)
 		if err != nil {
 			logger.Critical(err)
 		}
-		defer f.Close()
+
+		defer func() {
+			if err := f.Close(); err != nil {
+				logger.Criticalf("Error closing file: %s\n", err)
+			}
+		}()
 
 		_, err = blockCache.Get(c.Param("key"))
 		if err == (KeyNotFound{c.Param("key")}) {

config.go

@@ -179,7 +179,12 @@ func generateConfig(path string) error {
 	if err != nil {
 		return fmt.Errorf("could not generate config: %s", err)
 	}
-	defer output.Close()
+
+	defer func() {
+		if err := output.Close(); err != nil {
+			logger.Criticalf("Error closing file: %s\n", err)
+		}
+	}()
 
 	r := strings.NewReader(fmt.Sprintf(defaultConfig, ConfigVersion))
 	if _, err := io.Copy(output, r); err != nil {

logger.go

@@ -101,7 +101,7 @@ func createLogFile(fileName string) (*os.File, error) {
 		}
 	}
 
-	file, err := os.OpenFile(fileName, os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0666)
+	file, err := os.OpenFile(fileName, os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0600)
 	if err != nil {
 		return nil, fmt.Errorf("error opening log file: %s", err)
 	}

updater.go

@@ -46,7 +46,12 @@ func downloadFile(uri string, name string) error {
 	if err != nil {
 		return fmt.Errorf("error creating file: %s", err)
 	}
-	defer output.Close()
+
+	defer func() {
+		if err := output.Close(); err != nil {
+			logger.Criticalf("Error closing file: %s\n", err)
+		}
+	}()
 
 	response, err := http.Get(uri)
 	if err != nil {
@@ -124,7 +129,13 @@ func parseHostFile(fileName string, blockCache *MemoryBlockCache) error {
 	if err != nil {
 		return fmt.Errorf("error opening file: %s", err)
 	}
-	defer file.Close()
+
+	defer func() {
+		if err := file.Close(); err != nil {
+			logger.Criticalf("Error closing file: %s\n", err)
+		}
+	}()
+
 	scanner := bufio.NewScanner(file)
 	for scanner.Scan() {
 		line := scanner.Text()