Add an abstracted exporter class to reduce duplicated code and allow customizations.

Author: drupol

src/Exporter/AbstractExporter.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace drupol\phptree\Exporter;
+
+use drupol\phptree\Node\NodeInterface;
+use drupol\phptree\Node\ValueNodeInterface;
+
+/**
+ * Class AbstractExporter.
+ */
+abstract class AbstractExporter implements ExporterInterface
+{
+    /**
+     * Get a string representation of the node.
+     *
+     * @param \drupol\phptree\Node\NodeInterface $node
+     *   The node.
+     *
+     * @return string
+     *   The node representation.
+     */
+    protected function getNodeRepresentation(NodeInterface $node): string
+    {
+        if ($node instanceof ValueNodeInterface) {
+            return (string) $node->getValue();
+        }
+
+        return \sha1(\spl_object_hash($node));
+    }
+}

src/Exporter/Ascii.php

@@ -10,7 +10,7 @@
 /**
  * Class Ascii.
  */
-class Ascii implements ExporterInterface
+class Ascii extends AbstractExporter
 {
     /**
      * {@inheritdoc}
@@ -46,24 +46,6 @@ public function export(NodeInterface $node): string
         return $output;
     }
 
-    /**
-     * Get a string representation of the node.
-     *
-     * @param \drupol\phptree\Node\NodeInterface $node
-     *   The node.
-     *
-     * @return string
-     *   The node representation.
-     */
-    protected function getNodeRepresentation(NodeInterface $node): string
-    {
-        if ($node instanceof ValueNodeInterface) {
-            return (string) $node->getValue();
-        }
-
-        return \sha1(\spl_object_hash($node));
-    }
-
     /**
      * Export the tree in an array.
      *

src/Exporter/Graph.php

@@ -6,14 +6,13 @@
 
 use drupol\phptree\Node\AttributeNodeInterface;
 use drupol\phptree\Node\NodeInterface;
-use drupol\phptree\Node\ValueNodeInterface;
 use Fhaculty\Graph\Graph as OriginalGraph;
 use Fhaculty\Graph\Vertex;
 
 /**
  * Class Graph.
  */
-class Graph implements ExporterInterface
+class Graph extends AbstractExporter
 {
     /**
      * The graph.
@@ -59,9 +58,10 @@ protected function createVertex(NodeInterface $node): Vertex
         if (false === $this->getGraph()->hasVertex($vertexId)) {
             $vertex = $this->getGraph()->createVertex($vertexId);
 
-            if ($node instanceof ValueNodeInterface) {
-                $vertex->setAttribute('graphviz.label', $node->getValue());
-            }
+            $vertex->setAttribute(
+                'graphviz.label',
+                $this->getNodeRepresentation($node)
+            );
 
             if ($node instanceof AttributeNodeInterface) {
                 foreach ($node->getAttributes() as $key => $value) {

src/Exporter/Gv.php

@@ -6,12 +6,11 @@
 
 use drupol\phptree\Node\AttributeNodeInterface;
 use drupol\phptree\Node\NodeInterface;
-use drupol\phptree\Node\ValueNodeInterface;
 
 /**
  * Class Gv.
  */
-class Gv implements ExporterInterface
+class Gv extends AbstractExporter
 {
     /**
      * The graph attributes.
@@ -217,11 +216,9 @@ protected function getHash(NodeInterface $node): string
      */
     protected function getNodeAttributes(NodeInterface $node): array
     {
-        $attributes = [];
-
-        if ($node instanceof ValueNodeInterface) {
-            $attributes['label'] = $node->getValue();
-        }
+        $attributes = [
+            'label' => $this->getNodeRepresentation($node),
+        ];
 
         if ($node instanceof AttributeNodeInterface) {
             foreach ($node->getAttributes() as $key => $value) {

src/Exporter/SimpleArray.php

@@ -10,7 +10,7 @@
 /**
  * Class SimpleArray.
  */
-class SimpleArray implements ExporterInterface
+class SimpleArray extends AbstractExporter
 {
     /**
      * {@inheritdoc}
@@ -28,7 +28,7 @@ public function export(NodeInterface $node)
         }
 
         return [] === $children ?
-            ['value' => $node->getValue()] :
-            ['value' => $node->getValue(), 'children' => $children];
+            ['value' => $this->getNodeRepresentation($node)] :
+            ['value' => $this->getNodeRepresentation($node), 'children' => $children];
     }
 }

src/Exporter/Text.php

@@ -10,7 +10,7 @@
 /**
  * Class Text.
  */
-class Text implements ExporterInterface
+class Text extends AbstractExporter
 {
     /**
      * {@inheritdoc}
@@ -25,23 +25,7 @@ public function export(NodeInterface $node): string
         }
 
         return [] === $children ?
-            \sprintf('[%s]', $this->getNodeValue($node)) :
-            \sprintf('[%s%s]', $this->getNodeValue($node), \implode('', $children));
-    }
-
-    /**
-     * Get a string representation of a node.
-     *
-     * @param \drupol\phptree\Node\NodeInterface $node
-     *   The node.
-     *
-     * @return string
-     *   The string representation.
-     */
-    protected function getNodeValue(NodeInterface $node): string
-    {
-        return $node instanceof ValueNodeInterface ?
-            (string) $node->getValue() :
-            (string) \spl_object_hash($node);
+            \sprintf('[%s]', $this->getNodeRepresentation($node)) :
+            \sprintf('[%s%s]', $this->getNodeRepresentation($node), \implode('', $children));
     }
 }