Simplify the exporters.

Author: drupol

src/Exporter/Ascii.php

@@ -15,7 +15,7 @@
 /**
  * Class Ascii.
  */
-class Ascii extends AbstractExporter
+final class Ascii extends AbstractExporter
 {
     /**
      * {@inheritdoc}

src/Exporter/Graph.php

@@ -12,7 +12,7 @@
 /**
  * Class Graph.
  */
-class Graph extends AbstractExporter
+final class Graph extends AbstractExporter
 {
     /**
      * The graph.

src/Exporter/Gv.php

@@ -15,7 +15,7 @@
 /**
  * Class Gv.
  */
-class Gv extends AbstractExporter
+final class Gv extends AbstractExporter
 {
     /**
      * The graph attributes.

src/Exporter/Image.php

@@ -7,13 +7,12 @@
 use Exception;
 use loophp\phptree\Node\NodeInterface;
 
-use const LOCK_EX;
 use const PHP_OS;
 
 /**
  * Class Image.
  */
-class Image extends Gv
+final class Image extends AbstractExporter
 {
     /**
      * @var string
@@ -44,13 +43,13 @@ public function __construct()
      */
     public function export(NodeInterface $node): string
     {
-        $path = $this->getTemporaryFile();
-
-        $this->writeToFile($path, parent::export($node));
+        if (false === $tmp = tempnam(sys_get_temp_dir(), 'phptree-export-')) {
+            return '';
+        }
 
-        system($this->getConvertCommand($path));
+        file_put_contents($tmp, (new Gv())->export($node));
 
-        return sprintf('%s.%s', $path, $this->getFormat());
+        return shell_exec($this->getConvertCommand($tmp));
     }
 
     /**
@@ -105,47 +104,10 @@ public function setFormat(string $format): self
     private function getConvertCommand(string $path): string
     {
         return sprintf(
-            '%s -T%s %s -o %s.%s',
+            '%s -T%s %s',
             $this->getExecutable(),
             $this->getFormat(),
-            $path,
-            $path,
-            $this->getFormat()
+            $path
         );
     }
-
-    /**
-     * @throws Exception
-     *
-     * @return string
-     */
-    private function getTemporaryFile(): string
-    {
-        $path = tempnam(sys_get_temp_dir(), 'graphviz');
-
-        if (false === $path) {
-            throw new Exception('Unable to get temporary file name for graphviz script');
-        }
-
-        return $path;
-    }
-
-    /**
-     * @param string $path
-     * @param string $content
-     *
-     * @throws Exception
-     *
-     * @return bool
-     */
-    private function writeToFile(string $path, string $content): bool
-    {
-        $ret = file_put_contents($path, $content, LOCK_EX);
-
-        if (false === $ret) {
-            throw new Exception('Unable to write graphviz script to temporary file');
-        }
-
-        return true;
-    }
 }

src/Exporter/SimpleArray.php

@@ -11,7 +11,7 @@
 /**
  * Class SimpleArray.
  */
-class SimpleArray extends AbstractExporter
+final class SimpleArray extends AbstractExporter
 {
     /**
      * {@inheritdoc}

src/Exporter/Text.php

@@ -10,7 +10,7 @@
 /**
  * Class Text.
  */
-class Text extends AbstractExporter
+final class Text extends AbstractExporter
 {
     /**
      * {@inheritdoc}