From a7024d0f987ad394b9738b6bc8d5a303b23e460c Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Fri, 26 Feb 2021 07:30:37 -0800 Subject: [PATCH] feat: mark Entity and Model to be regular classes The Model/Entity being abstract caused compilation errors as TS 4.2 reinforces abstract checks. https://devblogs.microsoft.com/typescript/announcing-typescript-4-2/ https://github.com/microsoft/TypeScript/pull/36392 Signed-off-by: Raymond Feng --- packages/repository/src/model.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/repository/src/model.ts b/packages/repository/src/model.ts index 983b22d10a29..f7a84e5d4ca5 100644 --- a/packages/repository/src/model.ts +++ b/packages/repository/src/model.ts @@ -309,7 +309,7 @@ function asObject(value: any, options?: Options): any { /** * Base class for models */ -export abstract class Model { +export class Model { static get modelName(): string { return this.definition?.name || this.name; } @@ -418,7 +418,7 @@ export abstract class ValueObject extends Model implements Persistable {} /** * Base class for entities which have unique ids */ -export abstract class Entity extends Model implements Persistable { +export class Entity extends Model implements Persistable { /** * Get the names of identity properties (primary keys). */