Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Remove the default CSI component images in longhorn-manager #9580

Closed
c3y1huang opened this issue Oct 7, 2024 · 2 comments
Closed
Assignees
Labels
area/install-uninstall-upgrade Install, Uninstall or Upgrade related component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied.
Milestone

Comments

@c3y1huang
Copy link
Contributor

Is your improvement request related to a feature? Please describe (👍 if you like this request)

We have already defined the default images in the YAML and chart. To prevent confusion, we should remove these duplicated definitions.

Describe the solution you'd like

Remove the default CSI component images in longhorn-manager.

Describe alternatives you've considered

Additional context

#9564 (comment)

@c3y1huang c3y1huang added component/longhorn-manager Longhorn manager (control plane) area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Oct 7, 2024
@c3y1huang c3y1huang self-assigned this Oct 7, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Longhorn Sprint Oct 7, 2024
@innobead innobead added this to the v1.8.0 milestone Oct 7, 2024
@c3y1huang c3y1huang moved this from New Issues to Analysis and Design in Longhorn Sprint Nov 1, 2024
@c3y1huang c3y1huang moved this from Analysis and Design to New Issues in Longhorn Sprint Nov 6, 2024
@c3y1huang c3y1huang moved this from New Issues to Analysis and Design in Longhorn Sprint Nov 8, 2024
@c3y1huang c3y1huang moved this from Analysis and Design to Implement in Longhorn Sprint Nov 8, 2024
@c3y1huang c3y1huang moved this from Implement to Review in Longhorn Sprint Nov 8, 2024
@longhorn-io-github-bot
Copy link
Collaborator

longhorn-io-github-bot commented Nov 8, 2024

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at chore: remove default CSI component images longhorn-manager#3256

  • Which areas/issues this PR might have potential impacts on?
    Area longhorn-manager, install/uninstall
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@c3y1huang c3y1huang moved this from Review to Ready For Testing in Longhorn Sprint Nov 10, 2024
@yangchiu yangchiu self-assigned this Nov 12, 2024
@yangchiu
Copy link
Member

Verification passed on master-head (longhorn-manager 70ac3bc). Daily regression test passed without CSI-related test case failures: https://ci.longhorn.io/job/public/job/master/job/sles/job/amd64/job/longhorn-tests-sles-amd64/1093/

@github-project-automation github-project-automation bot moved this from Ready For Testing to Closed in Longhorn Sprint Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install-uninstall-upgrade Install, Uninstall or Upgrade related component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied.
Projects
Status: Closed
Development

No branches or pull requests

4 participants