Skip to content

Bump actions/upload-artifact from 4.1.0 to 4.2.0 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 2 commits into from
Closed

Bump actions/upload-artifact from 4.1.0 to 4.2.0 #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43a6b39
[Windows] Fix resize crash
loic-sharma Jan 22, 2024
363ca56
Bump actions/upload-artifact from 4.1.0 to 4.2.0
dependabot[bot] Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/scorecards-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:

# Upload the results as artifacts (optional).
- name: "Upload artifact"
uses: actions/upload-artifact@1eb3cb2b3e0f29609092a73eb033bb759a334595
uses: actions/upload-artifact@694cdabd8bdb0f10b2cea11669e1bf5453eed0a6
with:
name: SARIF file
path: results.sarif
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/third_party_scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: "extract deps, find commit hash, pass to osv-scanner"
run: python ci/scan_deps.py --output osv-lockfile-${{github.sha}}.json
- name: "upload osv-scanner deps"
uses: actions/upload-artifact@1eb3cb2b3e0f29609092a73eb033bb759a334595
uses: actions/upload-artifact@694cdabd8bdb0f10b2cea11669e1bf5453eed0a6
with:
# use github.ref in name to avoid duplicated artifacts
name: osv-lockfile-${{github.sha}}
Expand Down
13 changes: 9 additions & 4 deletions shell/platform/windows/flutter_windows_view.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,10 +597,15 @@ void FlutterWindowsView::OnFramePresented() {
switch (resize_status_) {
case ResizeState::kResizeStarted:
// The caller must first call |OnFrameGenerated| or
// |OnEmptyFrameGenerated| before calling this method. This status
// indicates the caller did not call these methods or ignored their
// result.
FML_UNREACHABLE();
// |OnEmptyFrameGenerated| before calling this method. This
// indicates one of the following:
//
// 1. The caller did not call these methods.
// 2. The caller ignored these methods' result.
// 3. The platform thread started a resize after the caller called these
// methods. We might have presented a frame of the wrong size to the
// view.
return;
case ResizeState::kFrameGenerated: {
// A frame was generated for a pending resize.
// Unblock the platform thread.
Expand Down