Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of LogStash::SHUTDOWN #18

Open
andsel opened this issue Sep 20, 2021 · 2 comments
Open

Remove usage of LogStash::SHUTDOWN #18

andsel opened this issue Sep 20, 2021 · 2 comments

Comments

@andsel
Copy link
Contributor

andsel commented Sep 20, 2021

With the removal of Ruby Execution Engine elastic/logstash#12517 the LogStash::SHUTDOWN was removed.
This plugin starts failing on 8.0.

Build scan:
https://app.travis-ci.com/github/logstash-plugins/logstash-output-nagios_nsca/jobs/538358481#L480

Repro line:
NA

Reproduces locally?:
Yes

Applicable branches:
master

Failure history:

Failure excerpt:

logstash_1_d54db825a42b | Failures:
logstash_1_d54db825a42b | 
logstash_1_d54db825a42b |   1) LogStash::Outputs::NagiosNsca send send the event to nagios
logstash_1_d54db825a42b |      Failure/Error: return if event == LogStash::SHUTDOWN
logstash_1_d54db825a42b |      
logstash_1_d54db825a42b |      NameError:
logstash_1_d54db825a42b |        uninitialized constant LogStash::SHUTDOWN
logstash_1_d54db825a42b |        Did you mean?  LogStash::ShutdownSignal
logstash_1_d54db825a42b |      # ./lib/logstash/outputs/nagios_nsca.rb:69:in `receive'
logstash_1_d54db825a42b |      # ./spec/outputs/nagios_nsca_spec.rb:26:in `block in <main>'
@andsel
Copy link
Contributor Author

andsel commented Sep 20, 2021

/cc @roaksoax for prioritize

@Hellnino18
Copy link

Hi there !

What about this issue ? Do you plan to fix this problem with any ETA ? I can't use nagios_nsca output anymore since I upgraded to Elastic 8.4.3.

Thanks for your help (Elastic support told me to contact the dev platform about this issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants