Add support for pipeline to decode from metadata target_ingest_pipeline #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st_pipeline]` Fixes: logstash-plugins#1112
…st_pipeline]` Fixes: logstash-plugins#1112
…ash-output-elasticsearch into allow_metadata_pipeline # Conflicts: # CHANGELOG.md # spec/unit/outputs/elasticsearch_spec.rb
kaisecheng
changed the title
yaauie
reviewed
Jan 31, 2023
yaauie
reviewed
Jan 31, 2023
Co-authored-by: Ry Biesemeyer <[email protected]>
Co-authored-by: Ry Biesemeyer <[email protected]>
Co-authored-by: Ry Biesemeyer <[email protected]>
Co-authored-by: Ry Biesemeyer <[email protected]>
Contributor
Author
|
All test cases run successfully but one of the unit test stages is frozen after tests are done. |
…asticsearch into allow_metadata_pipeline # Conflicts: # CHANGELOG.md # logstash-output-elasticsearch.gemspec
yaauie
approved these changes
Feb 7, 2023
Contributor
yaauie
left a comment
yaauie
left a comment
There was a problem hiding this comment.
Looks to work as-advertised. Unsure about the failing spec and can't trigger Travis builds for some reason, will attempt to replicate when I get home in a few hours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1112
This PR allows
pipelineoption to take value from[@metadata][target_ingest_pipeline]ifpipelineis not set.if
[@metadata][target_ingest_pipeline]gives empty string, thepipelinewon't be setThanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/