Merge pull request #1 from wiibaa/require-source

Richard Pijnenburg · Richard Pijnenburg · commit 8a9c93a97d6b · 2014-11-02T21:35:59.000Z
set source config as required
diff --git a/lib/logstash/filters/xml.rb b/lib/logstash/filters/xml.rb
@@ -13,16 +13,16 @@ class LogStash::Filters::Xml < LogStash::Filters::Base
   #
   #     source => source_field
   #
-  # For example, if you have the whole xml document in your @message field:
+  # For example, if you have the whole xml document in your message field:
   #
   #     filter {
   #       xml {
   #         source => "message"
   #       }
   #     }
   #
-  # The above would parse the xml from the @message field
-  config :source, :validate => :string
+  # The above would parse the xml from the message field
+  config :source, :validate => :string, :required => true
 
   # Define target for placing the data
   #

Original file line number	Diff line number	Diff line change
`@@ -13,16 +13,16 @@ class LogStash::Filters::Xml < LogStash::Filters::Base`
`13`	`13`	`#`
`14`	`14`	`# source => source_field`
`15`	`15`	`#`
`16`		`- # For example, if you have the whole xml document in your @message field:`
	`16`	`+ # For example, if you have the whole xml document in your message field:`
`17`	`17`	`#`
`18`	`18`	`# filter {`
`19`	`19`	`# xml {`
`20`	`20`	`# source => "message"`
`21`	`21`	`# }`
`22`	`22`	`# }`
`23`	`23`	`#`
`24`		`- # The above would parse the xml from the @message field`
`25`		`- config :source, :validate => :string`
	`24`	`+ # The above would parse the xml from the message field`
	`25`	`+ config :source, :validate => :string, :required => true`
`26`	`26`
`27`	`27`	`# Define target for placing the data`
`28`	`28`	`#`