Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize backup extension name #141

Closed
strawgate opened this issue Dec 17, 2021 · 6 comments
Closed

Customize backup extension name #141

strawgate opened this issue Dec 17, 2021 · 6 comments
Assignees
@xeraph
Labels
enhancement New feature or request patch released

Comments

@strawgate
Copy link
Contributor

We want to use the presence of a backed up jar file to know that it has been remediated already via other tools. The problem is .bak is a ubiquitous extension and may not actually indicate the jar next to it was remediated, it could have been created for any reason. Allowing customization would allow for us to save the backup file as something like .log4j.bak
@jgstew
Copy link
Contributor

jgstew commented Dec 17, 2021 •
edited
Loading

I agree, that makes sense. Or maybe even .log4jscan.bak?

@xeraph
Copy link
Contributor

xeraph commented Dec 18, 2021

I'm considering backing up all files in one ZIP file for convenience.

@xeraph xeraph self-assigned this Dec 18, 2021
@xeraph xeraph added the enhancement New feature or request label Dec 18, 2021
@strawgate
Copy link
Contributor Author

I think that would have the opposite impact and would make identifying which jar to restore more difficult so hopefully that would be optional?

@xeraph
Copy link
Contributor

xeraph commented Dec 18, 2021

Sure :D

@xeraph
Copy link
Contributor

xeraph commented Dec 21, 2021

@strawgate Would you test v2.5.0 release? You don't have to think about file extension. :D

@xeraph
Copy link
Contributor

xeraph commented Dec 21, 2021

@strawgate --backup-ext option is added in v2.5.2. Would you try it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xeraph xeraph

Labels
enhancement New feature or request patch released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgstew @xeraph @strawgate