Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeSuffix = "nodes.vcluster.com" #2570

Open
pasztorl opened this issue Mar 9, 2025 · 2 comments
Open

NodeSuffix = "nodes.vcluster.com" #2570

pasztorl opened this issue Mar 9, 2025 · 2 comments

Comments

@pasztorl
Copy link

pasztorl commented Mar 9, 2025

Is your feature request related to a problem?

I see that is currently a constant.
It would be nice if it can be configurable because for now the nodenames can't resolveable because they not exists at .nodes.vcluster.com so this constant is not correct by default and can't changeable.

Which solution do you suggest?

Make it configurable for example:

networking:
  advanced:
    NodeSuffix: x.y.z

Which alternative solutions exist?

No response

Additional context

No response

@matskiv
Copy link
Contributor

matskiv commented Mar 10, 2025

This domain should be resolvable from inside the vcluster. When you say it is not resolvable, from where have you tested it?
P.S: The goal of this domain is not to provide universally resolvable address, but provide a hostname that will be resolvable by workloads deployed in vcluster, AFAIK Prometheus deployed in vcluster is one of the use cases.

@pasztorl
Copy link
Author

yes, from inside is resolveable because of the custom coredns config what is set on install time. but this domain is still fake. it is little annoying (probably for just me?) that the only usage for this constant is looks like marketing purporses. or there is an other reason to keep it constant?
Also i think the "fake node" feature is connected to this issue. If i use fake node feature there are also constants set, like fake kernel version or container runtime. it think this can be more useable if the admin can decide what to show what not inside the vcluster env.
i know it is not a big deal, if someone have problem with this just modify these contstants then recompile the code, but i think this can be a great feature with minimal development effort..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants