Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm version check fails with Fedora packaged Helm #2545

Open
jawsper opened this issue Feb 26, 2025 · 1 comment
Open

Helm version check fails with Fedora packaged Helm #2545

jawsper opened this issue Feb 26, 2025 · 1 comment
Labels

Comments

@jawsper
Copy link

jawsper commented Feb 26, 2025

What happened?

Running Fedora 41, with Fedora package helm installed (version 3.17.0-1.fc41).

helm version --client --template '{{.Version}}' outputs 3.17.0

Running vcluster create ... or vcluster delete ... fails with the error message:

fatal please ensure that the "helm" binary in your PATH is valid. Currently only Helm >= v3.10.0 is supported

What did you expect to happen?

No error about helm not being valid.

How can we reproduce it (as minimally and precisely as possible)?

On Fedora 41, install helm:

sudo dnf install helm

And check that the version is missing the v prefix:

helm version --client --template '{{.Version}}'

Anything else we need to know?

From looking at the code, it seems that the semver package requires the semver to start with a v which is not the case for the helm I have installed.

Host cluster Kubernetes version

$ kubectl version
Client Version: v1.30.9-dispatcher
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.30.9-gke.1046000

vcluster version

$ vcluster --version
vcluster version 0.22.4

VCluster Config

# My vcluster.yaml / values.yaml here
controlPlane:
  distro:
    k3s:
      enabled: true
  statefulSet:
    resources:
      limits:
        memory: 4Gi
    scheduling:
      podManagementPolicy: OrderedReady
    persistence:
      volumeClaim:
        size: 10Gi
sync:
  fromHost:
    ingressClasses:
      enabled: true
  toHost:
    ingresses:
      enabled: true
    serviceAccounts:
      enabled: true

@cbron
Copy link
Contributor

cbron commented Mar 7, 2025

Looks like that is coming from here: https://github.com/loft-sh/vcluster/blob/main/pkg/util/clihelper/clihelper.go#L119-L125
And the custom version is throwing off the check. Feel free to submit a PR, otherwise I'll throw this in our backlog to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants