Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cross-tab notifications #5

Closed
thgreasi opened this issue Feb 4, 2017 · 10 comments
Closed

Add support for cross-tab notifications #5

thgreasi opened this issue Feb 4, 2017 · 10 comments

Comments

@thgreasi
Copy link
Member

thgreasi commented Feb 4, 2017

As noted in:
localForage/localForage#104
localForage/localForage#244
localForage/localForage#622

@dmurph
Copy link

dmurph commented Feb 4, 2017

Indexedb observers are now working behind a flag in Canary

@thgreasi
Copy link
Member Author

thgreasi commented Feb 4, 2017

That's great. I'm thinking about an initial release using localstorage to propagate cross tab events. After IndexedDB events gets implemented without a flag from one more browser engine, we can plan upgrading the architecture.

@TheNeikos
Copy link

Thanks a lot for working on this!

@dmurph
Copy link

dmurph commented Feb 5, 2017

Awesome! If you have any time to take a look at the current API (see sample here:
https://googlechrome.github.io/samples/indexeddb-observers/) any feedback would be greatly appreciated.

@thgreasi
Copy link
Member Author

thgreasi commented Feb 9, 2017

Just opened PR #6. It would be great to receive some feedback and then release during the weekend.

@thgreasi
Copy link
Member Author

Just meged #6 and released v1.1.0 which includes cross-tab observation.

@TheNeikos
Copy link

Thanks a lot. Going to implement this now

@deiu
Copy link

deiu commented Jan 12, 2018

Hi! Is this feature supported in all browsers? It would be useful to have a note in the README about current browser support.

Also, are there any plans to merge this feature into the main repo?

Edit: I'm only interested in support for IndexedDB, not localStorage.

@thgreasi
Copy link
Member Author

@deiu This is based on localStorage events, so it should work wherever localStorage is supported.
My main concern would be private browsing, which essentially beats the purpose, since the user by definition requests for an isolated tab, so this should be a non-issue.

@deiu
Copy link

deiu commented Jan 12, 2018

Thanks for the quick reply! I see. I knew the eventListener for localStorage is available but for some reason I'm thinking by default of IndexedDB when using localForage. After reading the thread again, I see you mentioned waiting for native IndexedDB support in browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants