Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The usage of OpenStruct #206

Open
dimameshcharakou opened this issue Dec 22, 2021 · 0 comments
Open

The usage of OpenStruct #206

dimameshcharakou opened this issue Dec 22, 2021 · 0 comments

Comments

@dimameshcharakou
Copy link
Contributor

The ruby maintainers started to recommend not using OpenStruct
https://docs.ruby-lang.org/en/3.0.0/OpenStruct.html#class-OpenStruct-label-Caveats

Also the related rule was added to rubocop:
https://docs.rubocop.org/rubocop/cops_style.html#styleopenstructuse
ATM, it's disabled: https://github.com/local-ch/lhc/pull/205/files#diff-4f894049af3375c2bd4e608f546f8d4a0eed95464efcdea850993200db9fef5cR274

It might make sense to think about replacing OpenStruct with Struct or Hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant