-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background blur halo effect #414
Comments
Thanks for the feedback @dekatr0n |
Alright yeah |
Fixed by #415 |
I'm amazed at your speed and dedication to this project ❤️ I would like to help test it out, but I'm not exactly sure how. I tried downloading and installing the Windows build artifact from here, but I cannot see the fix in action. Do I have to build it myself? |
Yes.. that's supposed to be a build that includes the fix. However the fix is in the .effect files and not the .dll file (assuming Windows). Can you see that you copy in the effects as well from the build? |
@dekatr0n thanks for the thorough testing, i appreciate your help! the focal blur is different in nature. it doesn't use a mask per-se, so we can't block the non-masked pixels while i think it might be possible to get the focal blur to be sharper around the edges, it will add (in my current analysis) some significant computation overhead in the pixel shader it think we should merge the halo fix for now, and come back to focal blur later |
That makes sense. Thanks for the prompt fix! |
Is your feature request related to a problem? Please describe.
I use the plugin to blur my background, but I've noticed that the blurred background often has a halo effect around the detected mask, where the colors of the subject bleed into the blurred background. This is especially noticeable if you stand against a dark background while wearing light colors.
Describe the solution you'd like
While blurring the background, the filter should only use the pixels outside the detected mask to create the blur effect.
Describe alternatives you've considered
I've noticed that the background blur implementations in Google Meet and Zoom do this correctly, and there is no halo effect.
Additional context
I'm not exactly sure how this can be approached from an implementation POV, but maybe the "Repeat edge pixels" feature of After Effects can be some inspiration?
The text was updated successfully, but these errors were encountered: