Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: retry on subscribe failures #195

Open
orbitalturtle opened this issue Jan 6, 2025 · 1 comment
Open

Task: retry on subscribe failures #195

orbitalturtle opened this issue Jan 6, 2025 · 1 comment
Assignees

Comments

@orbitalturtle
Copy link
Collaborator

Description

Following up on #194, we should try to make LNDK a bit more resilient in the face of temporary, short-lived network errors, or LND restarts. Otherwise, if there's even just one short-lived error thrown, LNDK will just shut down. This means making sure to retry establishing a connection when subscribe_custom_messages or subscribe_peer_events return connection errors.

As @a-mpch mentioned, though, during this period it's possible we'll miss peer message events while we're waiting to reconnect, which can cause payment failures, etc. To get around the problem with missing peer events, we can call ListPeers to double-check if the OnionMessenger is totally synced up with LND.

@a-mpch
Copy link
Contributor

a-mpch commented Jan 7, 2025

I'll be working on this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants