Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double counting of a patch? #9

Open
chail opened this issue Jun 29, 2018 · 0 comments
Open

double counting of a patch? #9

chail opened this issue Jun 29, 2018 · 0 comments

Comments

@chail
Copy link

chail commented Jun 29, 2018

This was a really interesting paper! Thanks for providing the code.

I had adapted parts of this pipeline to work with a custom TF model. I was finding that in prediction_difference_analysis.py one of the patches was evaluated twice (by visualising the counts variable, and adding a check that every window = windows[w] is unique). I believe it occurs in lines 140-141, in which the upper index is win_idx+1, but win_idx is already incremented in line 109?

Another minor comment, should line 217 check that self.prob_tar=True?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant