Skip to content

[llvm-readobj][offload] Fix llvm-readobj --all on MachO #175912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikic merged 2 commits into from
Jan 15, 2026
Merged

[llvm-readobj][offload] Fix llvm-readobj --all on MachO #175912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c654f4
[llvm-readobj][offload] Fix llvm-readobj --all on MachO
nikic Jan 14, 2026
573e05b
Adjust comment style
nikic Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/lib/Object/OffloadBundle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,9 @@ Error OffloadBundleFatBin::extractBundle(const ObjectFile &Source) {

Error object::extractOffloadBundleFatBinary(
const ObjectFile &Obj, SmallVectorImpl<OffloadBundleFatBin> &Bundles) {
assert((Obj.isELF() || Obj.isCOFF()) && "Invalid file type");
// Ignore unsupported object formats.
if (!Obj.isELF() && !Obj.isCOFF())
return Error::success();

// Iterate through Sections until we find an offload_bundle section.
for (SectionRef Sec : Obj.sections()) {
Expand Down
34 changes: 34 additions & 0 deletions llvm/test/tools/llvm-readobj/MachO/all.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# RUN: yaml2obj %s | llvm-readobj --all - | FileCheck %s

## Make sure that --all at least doesn't crash.

# CHECK: Format: Mach-O arm
# CHECK: Arch: arm
# CHECK: AddressSize: 32bit
# CHECK: MachHeader {
# CHECK: Magic: Magic (0xFEEDFACE)
# CHECK: CpuType: Arm (0xC)
# CHECK: CpuSubType: CPU_SUBTYPE_ARM_V7 (0x9)
# CHECK: FileType: Relocatable (0x1)
# CHECK: NumOfLoadCommands: 0
# CHECK: SizeOfLoadCommands: 0
# CHECK: Flags [ (0x0)
# CHECK: ]
# CHECK: }
# CHECK: Sections [
# CHECK: ]
# CHECK: Relocations [
# CHECK: ]
# CHECK: UnwindInfo not implemented.
# CHECK: Symbols [
# CHECK: ]

--- !mach-o
FileHeader:
magic: 0xFEEDFACE
cputype: 0xC
cpusubtype: 0x9
filetype: 0x1
ncmds: 0
sizeofcmds: 0
flags: 0x0