Skip to content

[clang][driver][arm][macho] Default to -mframe-pointer=non-leaf. #154216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fpetrogalli merged 7 commits into from
Sep 9, 2025
Merged

[clang][driver][arm][macho] Default to -mframe-pointer=non-leaf. #154216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
565fddd
[clang][driver][arm][macho] Default to -mframe-pointer=non-leaf.
fpetrogalli Aug 18, 2025
f9cbe17
s/non_leaf_tailcall/leaf_tailcall/ [NFC]
fpetrogalli Sep 4, 2025
145e654
[driver][tests] Move tests closer to the group they belong to. [NFC]
fpetrogalli Sep 4, 2025
30b07e8
s/non_leaf_tailcall/leaf_tailcall/ [NFC]
fpetrogalli Sep 4, 2025
219c492
s/CHECK-32-MACHO/CHECK-MACHO-32/ [NFC]
fpetrogalli Sep 9, 2025
7377c9b
Remove unnecessary comments in test. [NFC]
fpetrogalli Sep 9, 2025
401cff9
Swap condition in OR to execute first the most common case. [NFC]
fpetrogalli Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/lib/Driver/ToolChains/CommonArgs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ static bool useLeafFramePointerForTargetByDefault(const llvm::Triple &Triple) {
(Triple.isAndroid() && !Triple.isARM()))
return false;

if ((Triple.isARM() || Triple.isThumb()) && Triple.isOSBinFormatMachO())
return false;

return true;
}

Expand Down
40 changes: 26 additions & 14 deletions clang/test/Driver/frame-pointer-elim.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@
// RUN: %clang -### -target armv7s-apple-ios -fomit-frame-pointer %s 2>&1 | \
// RUN: FileCheck --check-prefix=WARN-OMIT-7S %s
// WARN-OMIT-7S: warning: optimization flag '-fomit-frame-pointer' is not supported for target 'armv7s'
// WARN-OMIT-7S: "-mframe-pointer=all"
// WARN-OMIT-7S: "-mframe-pointer=non-leaf"

// RUN: %clang -### -target armv7k-apple-watchos -fomit-frame-pointer %s 2>&1 | \
// RUN: FileCheck --check-prefix=WARN-OMIT-7K %s
// WARN-OMIT-7K: warning: optimization flag '-fomit-frame-pointer' is not supported for target 'armv7k'
// WARN-OMIT-7K: "-mframe-pointer=all"
// WARN-OMIT-7K: "-mframe-pointer=non-leaf"

// RUN: %clang -### -target armv7s-apple-ios8.0 -momit-leaf-frame-pointer %s 2>&1 | \
// RUN: FileCheck --check-prefix=WARN-OMIT-LEAF-7S %s
Expand Down Expand Up @@ -190,22 +190,34 @@
// RUN: FileCheck --check-prefix=KEEP-NONE %s

// Check that for Apple bare metal targets, we're keeping frame pointers by default
// RUN: %clang -### --target=thumbv6m-apple-none-macho -S %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-ALL %s
// RUN: %clang -### --target=thumbv6m-apple-none-macho -S -fno-omit-frame-pointer %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-ALL %s
// RUN: %clang -### --target=armv6m-apple-none-macho -S %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-NON-LEAF %s
// RUN: %clang -### --target=armv6m-apple-none-macho -S -fno-omit-frame-pointer %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-NON-LEAF %s
// RUN: %clang -### --target=arm-apple-none-macho -S %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-ALL %s
// RUN: FileCheck --check-prefix=KEEP-NON-LEAF %s
// RUN: %clang -### --target=arm-apple-none-macho -S -fno-omit-frame-pointer %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-ALL %s
// RUN: %clang -### --target=thumbv6m-apple-none-macho -S -O1 %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-ALL %s
// RUN: %clang -### --target=thumbv6m-apple-none-macho -S -O1 -fno-omit-frame-pointer %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-ALL %s
// RUN: FileCheck --check-prefix=KEEP-NON-LEAF %s
// RUN: %clang -### --target=armv6m-apple-none-macho -S -O1 %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-NON-LEAF %s
// RUN: %clang -### --target=armv6m-apple-none-macho -S -O1 -fno-omit-frame-pointer %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-NON-LEAF %s
// RUN: %clang -### --target=arm-apple-none-macho -S -O1 %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-ALL %s
// RUN: FileCheck --check-prefix=KEEP-NON-LEAF %s
// RUN: %clang -### --target=arm-apple-none-macho -S -O1 -fno-omit-frame-pointer %s 2>&1 | \
// RUN: FileCheck --check-prefix=KEEP-ALL %s
// RUN: FileCheck --check-prefix=KEEP-NON-LEAF %s

// RUN: %clang --target=armv7-apple-macho -### -S %s 2>&1 \
// RUN: -fomit-frame-pointer \
// RUN: | FileCheck -check-prefix=KEEP-NONE %s

// RUN: %clang --target=armv7-apple-macho -### -S %s 2>&1 \
// RUN: -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer \
// RUN: | FileCheck -check-prefix=KEEP-ALL %s

// RUN: %clang --target=armv7-apple-macho -### -S %s 2>&1 \
// RUN: -fomit-frame-pointer -mno-omit-leaf-frame-pointer \
// RUN: | FileCheck -check-prefix=KEEP-NONE %s

// AArch64 bare metal targets behave like hosted targets
// RUN: %clang -### --target=aarch64-none-elf -S %s 2>&1 | \
Expand Down
4 changes: 4 additions & 0 deletions clang/test/Driver/frame-pointer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,16 @@
// RUN: %clang --target=loongarch64 -### -S -O3 %s -o %t.s 2>&1 | FileCheck -check-prefix=CHECK3-64 %s
// RUN: %clang --target=loongarch64 -### -S -Os %s -o %t.s 2>&1 | FileCheck -check-prefix=CHECKs-64 %s

// RUN: %clang --target=armv7-apple-macho -### -S %s -o %t.s 2>&1 | FileCheck -check-prefix=CHECK-MACHO-32 %s

// CHECK0-32: -mframe-pointer=all
// CHECK1-32-NOT: -mframe-pointer=all
// CHECK2-32-NOT: -mframe-pointer=all
// CHECK3-32-NOT: -mframe-pointer=all
// CHECKs-32-NOT: -mframe-pointer=all

// CHECK-MACHO-32: -mframe-pointer=non-leaf

// CHECK0-64: -mframe-pointer=all
// CHECK1-64-NOT: -mframe-pointer=all
// CHECK2-64-NOT: -mframe-pointer=all
Expand Down
30 changes: 30 additions & 0 deletions llvm/test/CodeGen/ARM/frame-chain.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,3 +223,33 @@ define dso_local void @required_fp(i32 %0, i32 %1) {
store i64 %8, ptr %6, align 8
ret void
}

define dso_local noundef i32 @leaf_tailcall(i32 noundef %0) {
; LEAF-FP-LABEL: leaf_tailcall:
; LEAF-FP: @ %bb.0:
; LEAF-FP-NEXT: .save {r11, lr}
; LEAF-FP-NEXT: push {r11, lr}
; LEAF-FP-NEXT: .setfp r11, sp
; LEAF-FP-NEXT: mov r11, sp
; LEAF-FP-NEXT: pop {r11, lr}
; LEAF-FP-NEXT: b leaf
;
; LEAF-FP-AAPCS-LABEL: leaf_tailcall:
; LEAF-FP-AAPCS: @ %bb.0:
; LEAF-FP-AAPCS-NEXT: .save {r11, lr}
; LEAF-FP-AAPCS-NEXT: push {r11, lr}
; LEAF-FP-AAPCS-NEXT: .setfp r11, sp
; LEAF-FP-AAPCS-NEXT: mov r11, sp
; LEAF-FP-AAPCS-NEXT: pop {r11, lr}
; LEAF-FP-AAPCS-NEXT: b leaf
;
; LEAF-NOFP-LABEL: leaf_tailcall:
; LEAF-NOFP: @ %bb.0:
; LEAF-NOFP-NEXT: b leaf
;
; LEAF-NOFP-AAPCS-LABEL: leaf_tailcall:
; LEAF-NOFP-AAPCS: @ %bb.0:
; LEAF-NOFP-AAPCS-NEXT: b leaf
%a = tail call noundef i32 @leaf(i32 noundef %0)
ret i32 %a
}
41 changes: 41 additions & 0 deletions llvm/test/CodeGen/Thumb/frame-chain.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,3 +273,44 @@ define dso_local void @required_fp(i32 %0, i32 %1) {
store i64 %8, ptr %6, align 8
ret void
}

define dso_local noundef i32 @leaf_tailcall(i32 noundef %0) {
; FP-LABEL: leaf_tailcall:
; FP: @ %bb.0:
; FP-NEXT: .save {r7, lr}
; FP-NEXT: push {r7, lr}
; FP-NEXT: .setfp r7, sp
; FP-NEXT: add r7, sp, #0
; FP-NEXT: bl leaf
; FP-NEXT: pop {r7, pc}
;
; FP-AAPCS-LABEL: leaf_tailcall:
; FP-AAPCS: @ %bb.0:
; FP-AAPCS-NEXT: .save {lr}
; FP-AAPCS-NEXT: push {lr}
; FP-AAPCS-NEXT: mov r3, r11
; FP-AAPCS-NEXT: .save {r11}
; FP-AAPCS-NEXT: push {r3}
; FP-AAPCS-NEXT: .setfp r11, sp
; FP-AAPCS-NEXT: mov r11, sp
; FP-AAPCS-NEXT: bl leaf
; FP-AAPCS-NEXT: pop {r1}
; FP-AAPCS-NEXT: mov r11, r1
; FP-AAPCS-NEXT: pop {pc}
;
; NOFP-LABEL: leaf_tailcall:
; NOFP: @ %bb.0:
; NOFP-NEXT: .save {r7, lr}
; NOFP-NEXT: push {r7, lr}
; NOFP-NEXT: bl leaf
; NOFP-NEXT: pop {r7, pc}
;
; NOFP-AAPCS-LABEL: leaf_tailcall:
; NOFP-AAPCS: @ %bb.0:
; NOFP-AAPCS-NEXT: .save {r7, lr}
; NOFP-AAPCS-NEXT: push {r7, lr}
; NOFP-AAPCS-NEXT: bl leaf
; NOFP-AAPCS-NEXT: pop {r7, pc}
%a = tail call noundef i32 @leaf(i32 noundef %0)
ret i32 %a
}
8 changes: 8 additions & 0 deletions llvm/test/CodeGen/Thumb2/frame-pointer.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,14 @@ define void @call_nononleaffpelim() "frame-pointer"="non-leaf" {
ret void
}

define void @call_nononleaffpelim_tailcall() "frame-pointer"="non-leaf" {
; CHECK-LABEL: call_nononleaffpelim_tailcall:
; CHECK-NOT: push
; CHECK: b foo
tail call void @foo()
ret void
}

; Has a high register clobbered, no need for a frame pointer.
define void @highreg() {
; CHECK-LABEL: highreg:
Expand Down