From f082583ed8105e7c8aa196dfd14b1dca0b026e3d Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Fri, 18 Jul 2025 18:53:19 +0900 Subject: [PATCH] StringMap: Remove redundant member init in constructor These are already zeroinitialized in the field definitions. --- llvm/lib/Support/StringMap.cpp | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/llvm/lib/Support/StringMap.cpp b/llvm/lib/Support/StringMap.cpp index 432e1fc343f1f..3432dc15ceef2 100644 --- a/llvm/lib/Support/StringMap.cpp +++ b/llvm/lib/Support/StringMap.cpp @@ -45,23 +45,15 @@ static inline unsigned *getHashTable(StringMapEntryBase **TheTable, uint32_t StringMapImpl::hash(StringRef Key) { return xxh3_64bits(Key); } -StringMapImpl::StringMapImpl(unsigned InitSize, unsigned itemSize) { - ItemSize = itemSize; - +StringMapImpl::StringMapImpl(unsigned InitSize, unsigned itemSize) + : ItemSize(itemSize) { // If a size is specified, initialize the table with that many buckets. if (InitSize) { // The table will grow when the number of entries reach 3/4 of the number of // buckets. To guarantee that "InitSize" number of entries can be inserted // in the table without growing, we allocate just what is needed here. init(getMinBucketToReserveForEntries(InitSize)); - return; } - - // Otherwise, initialize it with zero buckets to avoid the allocation. - TheTable = nullptr; - NumBuckets = 0; - NumItems = 0; - NumTombstones = 0; } void StringMapImpl::init(unsigned InitSize) {