[Clang] [Sema] Handle placeholders in '.*' expressions #83103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: None (Sirraide) ChangesWhen analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling Unfortunately, we were also doing that for This pr instead makes it so we check for all placeholders early if the operator is It’s worth noting that,
This fixes #53815. Full diff: https://github.com/llvm/llvm-project/pull/83103.diff 2 Files Affected:
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index c46f6338a5a125..f4b67e7b469418 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -14474,6 +14474,23 @@ ExprResult Sema::CreateOverloadedBinOp(SourceLocation OpLoc,
CurFPFeatureOverrides());
}
+ // If this is the .* operator, which is not overloadable, just
+ // create a built-in binary operator.
+ if (Opc == BO_PtrMemD) {
+ auto CheckPlaceholder = [&](Expr *&Arg) {
+ ExprResult Res = CheckPlaceholderExpr(Arg);
+ if (!Res.isInvalid())
+ Arg = Res.get();
+ return Res.isInvalid();
+ };
+
+ // CreateBuiltinBinOp() doesn't like it if we tell it to create a '.*'
+ // expression that contains placeholders (in either the LHS or RHS).
+ if (CheckPlaceholder(Args[0]) || CheckPlaceholder(Args[1]))
+ return ExprError();
+ return CreateBuiltinBinOp(OpLoc, Opc, Args[0], Args[1]);
+ }
+
// Always do placeholder-like conversions on the RHS.
if (checkPlaceholderForOverload(*this, Args[1]))
return ExprError();
@@ -14493,11 +14510,6 @@ ExprResult Sema::CreateOverloadedBinOp(SourceLocation OpLoc,
if (Opc == BO_Assign && !Args[0]->getType()->isOverloadableType())
return CreateBuiltinBinOp(OpLoc, Opc, Args[0], Args[1]);
- // If this is the .* operator, which is not overloadable, just
- // create a built-in binary operator.
- if (Opc == BO_PtrMemD)
- return CreateBuiltinBinOp(OpLoc, Opc, Args[0], Args[1]);
-
// Build the overload set.
OverloadCandidateSet CandidateSet(OpLoc, OverloadCandidateSet::CSK_Operator,
OverloadCandidateSet::OperatorRewriteInfo(
diff --git a/clang/test/SemaCXX/gh53815.cpp b/clang/test/SemaCXX/gh53815.cpp
new file mode 100644
index 00000000000000..326c911c7bfaf5
--- /dev/null
+++ b/clang/test/SemaCXX/gh53815.cpp
@@ -0,0 +1,21 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s
+// expected-no-diagnostics
+
+// Check that we don't crash due to forgetting to check for placeholders
+// in the RHS of '.*'.
+
+template <typename Fn>
+static bool has_explicitly_named_overload() {
+ return requires { Fn().*&Fn::operator(); };
+}
+
+int main() {
+ has_explicitly_named_overload<decltype([](auto){})>();
+}
+
+template <typename Fn>
+constexpr bool has_explicitly_named_overload_2() {
+ return requires { Fn().*&Fn::operator(); };
+}
+
+static_assert(!has_explicitly_named_overload_2<decltype([](auto){})>());
|
|
One more thing: this code seems to not crash and issue a diagnostic just fine if we simply remove the assertion, so that would also be an option, but I didn’t simply want to remove an assertion without fully knowing why it’s there, so I’ve gone with this as an alternative for now (it should be noted that the code path here is shared with Alternatively, we could also handle placeholders then and there instead of asserting on them. Thinking about this now, I’m not entirely sure what the best solution would be. |
|
It seems like the assertion has been in Clang since 2011, and back then, we were checking for placeholders in |
|
Yeah, it seems the change that ultimately caused this to break was made in 2011, which moved the handling of placeholders for this code path up into |
|
In my opinion, we ought to get |
|
Lastly, it also seems weird to me that a function called |
Ah yes, I keep forgetting about that |
Thanks. Just so you know, I still don’t have commit access, so you’d have to merge it for me—I should really look into obtaining commit access at this point perhaps |
Thank you for mentioning that! It turns out that GitHub is confusing: I read that to mean you had commit privs. :-D I support you getting commit privs, if you'd like to follow the process outlined here: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access but in the meantime, I'll push the button. |
|
@AaronBallman @Sirraide would this patch be reasonable to backport to the 18.x release branch? It fixes a problem with our application on the FreeBSD-CURRENT branch. SerenityOS/serenity#23365 |
Yeah, I think the changes are sufficiently safe and small enough that we could consider backporting. We have instructions on how to get that going here: https://www.llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches |
|
/cherry-pick d23ef9e |
|
Failed to cherry-pick: d23ef9e https://github.com/llvm/llvm-project/actions/runs/8146857249 Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request |
Sirraide
added a commit
to Sirraide/llvm-project
that referenced
this pull request
Mar 4, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]>
|
/cherry-pick Sirraide@74fa05d |
|
Failed to cherry-pick: Sirraide@74fa05d https://github.com/llvm/llvm-project/actions/runs/8147057328 Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request |
|
Hmm, I’m not sure I’m doing this properly; I’ll try and see if I can open a pr manually. |
tstellar
pushed a commit
that referenced
this pull request
Mar 13, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes #53815. --------- Co-authored-by: Aaron Ballman <[email protected]>
Closed
This was referenced Jul 17, 2024
ADKaster
pushed a commit
to ADKaster/llvm-project
that referenced
this pull request
Aug 2, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]>
compnerd
pushed a commit
to compnerd/llvm-project
that referenced
this pull request
Aug 10, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]> (cherry picked from commit d23ef9e)
compnerd
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Aug 12, 2024
[Clang] [Sema] Handle placeholders in '.*' expressions (llvm#83103)
ADKaster
pushed a commit
to ADKaster/llvm-project
that referenced
this pull request
Aug 19, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]> (cherry picked from commit d23ef9e)
DougGregor
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Aug 20, 2024
🍒 [Clang] [Sema] Handle placeholders in '.*' expressions (llvm#83103)
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Aug 23, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]>
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Aug 23, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]>
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Sep 5, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]>
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Sep 6, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]>
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Sep 9, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]>
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Petar Avramovic <[email protected]> Co-authored-by: Piotr Sobczak <[email protected]> [AMDGPU][GFX12] VOP encoding and codegen - add support for v_cvt fp8/… (llvm#78414) …bf8 instructions Add VOP1, VOP1_DPP8, VOP1_DPP16, VOP3, VOP3_DPP8, VOP3_DPP16 instructions that were supported on GFX940 (MI300): - V_CVT_F32_FP8 - V_CVT_F32_BF8 - V_CVT_PK_F32_FP8 - V_CVT_PK_F32_BF8 - V_CVT_PK_FP8_F32 - V_CVT_PK_BF8_F32 - V_CVT_SR_FP8_F32 - V_CVT_SR_BF8_F32 --------- Co-authored-by: Mateja Marjanovic <[email protected]> Co-authored-by: Mirko Brkušanin <[email protected]> (cherry picked from commit cfddb59) [RISCV] Support __riscv_v_fixed_vlen for vbool types. (llvm#76551) This adopts a similar behavior to AArch64 SVE, where bool vectors are represented as a vector of chars with 1/8 the number of elements. This ensures the vector always occupies a power of 2 number of bytes. A consequence of this is that vbool64_t, vbool32_t, and vool16_t can only be used with a vector length that guarantees at least 8 bits. [Docs] Fix documentation build. Missing ending `` after c92ad41 Backport '[clang] static operators should evaluate object argument (reland)' to release/18.x (llvm#80109) Cherry picked from commit ee01a2c. Closes llvm#80041, backport llvm#80108. Co-authored-by: Shafik Yaghmour <[email protected]> Co-authored-by: cor3ntin <[email protected]> Co-authored-by: Aaron Ballman <[email protected]> PR for llvm#79568 (llvm#80120) Backporting llvm#79568 to clang 18. [docs] Add release notes for Windows specific changes in 18.x (llvm#80011) [AArch64] Add some release notes items (llvm#79983) [C++20] [Modules] Don't perform ODR checks in GMF Close llvm#79240. See the linked issue for details. Given the frequency of issue reporting about false positive ODR checks (I received private issue reports too), I'd like to backport this to 18.x too. [clang] Fix unexpected `-Wconstant-logical-operand` in C23 (llvm#80724) C23 has `bool`, but logical operators still return int. Check that we're not in C to avoid false-positive -Wconstant-logical-operand. Fixes llvm#64356 (cherry picked from commit a18e92d) [18.x][Docs] Add release note about Clang-defined target OS macros (llvm#80044) The change is included in the 18.x release. Move the release note to the release branch and reformat. (cherry picked from commit b40d5b1) ReleaseNotes: mention -mtls-dialect=desc (llvm#82731) [Clang] Fixes to immediate-escalating functions (llvm#82281) * Consider that immediate escalating function can appear at global scope, fixing a crash * Lambda conversion to function pointer was sometimes not performed in an immediate function context when it should be. Fixes llvm#82258 (cherry picked from commit baf6bd3) [Clang] [Sema] Handle placeholders in '.*' expressions (llvm#83103) When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]> [InstCombine] Fix miscompilation in PR83947 (llvm#83993) https://github.com/llvm/llvm-project/blob/762f762504967efbe159db5c737154b989afc9bb/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp#L394-L407 Comment from @topperc: > This transforms assumes the mask is a non-zero splat. We only know its a splat and not provably all 0s. The mask is a constexpr that includes the address of the global variable. We can't resolve the constant expression to an exact value. Fixes llvm#83947. SystemZ release notes for 18.x. (llvm#84560) Remove support for EXPORTAS in def files to maintain ABI compatibility for COFFShortExport [clang][Sema] Fix a CTAD regression after 42239d2 (llvm#86914) The most recent declaration of a template as a friend can introduce a different template parameter depth compared to what we anticipate from a CTAD guide. Fixes llvm#86769 [clang] Avoid -Wshadow warning when init-capture named same as class field (llvm#74512) Shadowing warning doesn't make much sense since field is not available in lambda's body without capturing this. Fixes llvm#71976 [SLP]Fix a crash if the argument of call was affected by minbitwidth analysis. Need to support proper type conversion for function arguments to avoid compiler crash. Fix override keyword being print to the left side Previously, the `override` keyword in C++ was being print in the left side of a method decl, which is unsupported by C++ standard. This commit fixes that by setting the `CanPrintOnLeft` field to 0, forcing it to be print on the right side of the decl. Signed-off-by: Giuliano Belinassi <[email protected]> [clang codegen] Fix MS ABI detection of user-provided constructors. (llvm#90151) In the context of determining whether a class counts as an "aggregate", a constructor template counts as a user-provided constructor. Fixes llvm#86384 (cherry picked from commit 3ab4ae9) release/18.x: [libclc] Fix linking against libIRReader Fixes llvm#91551 Update llvm/test/Transforms/InstCombine/bit_ceil.ll Co-authored-by: Yingwei Zheng <[email protected]> [RISCV] Add a unaligned-scalar-mem feature like we had in clang 17. This is ORed with the fast-unaligned-access feature which applies to scalar and vector together.: Regular squash. Cobol/PlI changes from 785ddc60@https://gitlab.phidani.be/Chirag.Patel/lldb.git Cobol/PLI support added from 6cefb217f097ac@https://gitlab.phidani.be/Chirag.Patel/llvm.git [LLDB] added lldb rpmbuild spec file [RPMBuild] Added lldb rpmbuild support. [LLDBRpm] added version for yum update. [lldb_rpm] minor cleanup. Build fix rleated to RTTI. build fix. [DWARFASTParserLegacy] Initial support for union type. [lldb][LegacyTypeSystem] Changed struct/union member offset from bytes to bits to support DW_AT_data_bit_offset. [lldbrpm] changed version suffix. [LegacyASTContext] Fix var string length display. [LLDB][CobolUserExpression] Added AST node Function call place holder. build fix. [LLVM][Test] Fixed assembler round trip test. [LLDB][CobolUserExpression] Added ast evaluation for sizeof operator. [LLDB][CobolUserExpression] Added placeholder in parser for func call. [LLDB][CobolUserExpression] Added sizeof operator, temporary placeholder for LENGTH OF. [LLDB][PLIUserExpression] Fixed array indexing. [LLDB][ValueObjectPrinter] Skip summary if custom format is requested. [LLDB][PLILanguage] changed bitset size, read from array type name. [LLDB][ValueObject] Fixed pli var string length read. [LLDB][PLILanguage] Fixed support for var string summary formatter. [LLVM][DIBuilder][C-API] Added changes to add lexical scope info for auto variable for functions. [LLVM][AsmCodegen] Added raincode extention AT_lexical_scope. [LLDB][SymbolFileDWARF] Added support for RAINCODE_lexical_scope attribute. [LLDB][PLIUserExpression] Added sizeof operator support, it will be renamed to proper functiona name later. [LLDB][ValueObject] minor cleanup. [LLDB][PLIUserExpression] Added STORAGE/STG builtin func support. [LLDB][PLIUserExpression][CobolUserExpression] Added LENGTH() for Cobol and STG/STORAGE() for PL/I, removed sizeof operator for both. [LLDB][DWARFASTParserLegacy] Added placeholder for DW_TAG_reference_type. [LLVM][CodeGen][AsmPrinter] Added DW_AT_name attribute to TAG_array_type. [LLDB][DWARFExpression] minor cleanup. [LLDB][PLILanguage] Fixed bitset array size read from array type. [LLDB][LegacyASTContext] Moved bit array calculation to type system. [LLVM][AsmPrinter] Fixed TAG_array duplicate attribute export. [LLVM][C-API] Changes array type api. [LLDB][PLI/Cobol UserExpression] Fixed array indexing, removed c style [] index access. [LLDB][PLIUserExpression] minor fix. [LLDB] Fixed bug relating struct member name access for Cobol/PL1. fixed coding style/whitespace/typos. [LLDB][LegacyTypeSystem] Place holder beautification for edited types. [LLDB] rpm version upgrade. [LLDB][CobolUserExpression] Fixed pic string ref modifier. [LLDB][TypeSystem] Added support to mutate existing type length, fixed cobolUserExpression refmod for display type. [LLDB][CobolUserExpression] Fixed lower bound ref modifier. [LLDB][Cobol/PLI UserExpression] Fixed error while searching for var, do not fully resolve type. [LLDB][RPM] fixed rpm version. cleanup, reduce number of changes from trunk. cleanup, reduce number of changes fomr trunk. build fix. Build fix. Build fix. [LegacyASTContext] Fixed bug relating packed decimal going through ebcdic iconv. [LLVM][DebugInfo] Fixed DIExpression node uniquness issue. build fix. cleanup. Refactoring, moved LegacyASTContext to Plugin typeSystem Legacy. Refactoring, renamed TypeSystem class. build fix. build fix, cleanup. cleanup fixed assert failure. [CobolUserExpression] Added placeholder for simpe assignment operator. [CobolUserExpression] Added basic support for assigment to variables. [CobolUserExpression] Added cobol move-to set-to syntex support. [LegacyTypeSystem][CobolUserExpression] Added literal type double,string. Added TypeSystem Encoding helper functions. [CobolLexer] Added string,float literal type support. [PLIUserExpression] Added assignment operator support. [CobolUserExpression] Added assignment comp-3 support. [PLIUserExpression] Assignment added pli display type support. temporary build fix. DIExpression asmprinter, print null for invalid entry. [Cobol/PLI UserExpression] Assignment endianity bug fix. [Cobol/PLIUserExpression] fixed data extractpr assert, fixed int precision convertion written as zero. [Cobol/PLIUserExpression] Assignment display type assert failure. build fix. [PLIUserExpression] Added support for var string assignment. [LegacyUserExpression] Simple semantic check place-holder. [CobolUserexpression] Assignment expression fixed display, array types. [TypeSystem] fixed encode int precision bug for i64 to i32. [PLI/Cobol UserExpression] fixed support for assinment into refmod data type. [CobolUserExpression] Fixed assignment display/comp-3 regression. temporary build fix. python3 lib on server needs few changes for this build. [TypeSystemLegacy] Fixed edited type display, skip formatting for edited type. [lldbrpm] package lldb-python-script too. [CobolUserExpression] Fixed SelctorOf expression with array index access e.g (lldb)p LastName1 of VAR(1) of TAB. [CobolUserExpression] Assignment to packed decimal fixed, added digit count read support from dwarf instead of runtime calculation. [CoboUserExpression] Fixed assignment string invalid byte order. [PLIUserExpression] Fixed string padding with space. [CobolUserExpression] Fixed Assignment string space padding. [LegacyTypeSysten] fixed crash in encoding due to long length the assignment. [CobolUserExpression][PLIUserExpression] fixed segfault. [DebugInfo] export identifier case as insensitive for PLI/Cobol compiled units. [TypeSystemLegacy] Fixed minor bug with dataencoding. rebase build fix. [StackFrame] fixed support for cobol/pli modref select syntex. case-insensitive breakpoint resolution for PLI/Cobol languages. cleanup. build fix. added initial support for TAG_dynamic_type. added c/c++ api to create dynamic type debug info. [DebugInfo] Added support to generate dwarf attribute DW_AT_allocated for DW_TAG_dynamic_type [PLIUserExpression][CobolUserExpression] Fixed name variable lookup for few cases. [DWARFASTParserLegacy] Initial support to parse TAG_dynamic_type. [AsmPrinter] Fix minor mistake for TAG_dynamic DW_AT_allocated. [TypeSystemLegacy] Added dynamic type place holder. [LLVM][AsmPrinter] Allow OP_call2/4 expression on local variable location. build fix. [LLDB][CompilerType] Added support to fetch dynamic type info. [lldb][ValueObjectVariable] Added dynamic variable read support. [LLDB][ValueObjectVariable] Added allocated check for dynamic types. [LLDB][ValueObjectVariable] fixed TAG_dynamic type attributes optional. [LLVM][DebugInfoMetadata] Fixed minor function call. [LLDB][TypeSystemLegacy] Added dynamic type info support. build fix. for jekins, use python3 sharedlibs lldbrpm use python3. temporary build fix. [LLDB][DWARFExpression] Added temporary operation extension for address calculation with file address in dwarf v5. [LLVM][CodeGen] Fixed dynamic type dwarf expression call2/call4 assert. [LLVM][Verifier] Added dynamic type check. [LLVM][Verifier] Added debugInfo verifier dynamic type extra checks. [LLDB][TypeSystemLegacy] Added check to avoid direct nested dynaic types. [LLVM][DebugInfo] Adding DW_OP_call2/4 support in TAG_subrange attributes DW_AT_lower_bound, DW_AT_upper_bound. [LLDB] Added option to hide frames with invalid line entry target.hide-invalid-legacy-frames, this is a temporary placeholder and it will be moved to more suitable location in future. [LLDB][DataFormatters] Fixed printing of char arrays with non-default format. [LLDB][StackFrame] Added check for member name lookup to reject array of structs. [lldb][DataFormatters] fixed multi-dimesional string formatting. [LLDB][ValueObjectVariable] cleanup: proper error message. [LLVM][DwarfUnit] Added DW_OP_call2/call4 support for array type. [LLVM][DwarfCompileUnit] fixed assert failure with DW_OP_call2/call4. [DIBuilder] Added DW_AT_static_link support. [LLVM][C-API][DebugInfo] Added support for DW_AT_static_link. [DebugInfo] fixed minor bug with Staticlink attribute generation. [DebugInfo] static link cleanup. rebase build fix. [LLDB][DWARFParser] Added initial support to parse DW_AT_static_link. [LLDB][StackFrame] Added support to read static link address. [LLDB][StackFrameList] Added helper function to search stack list using static link. [LLDB][ValueObjectPrinter] regression fix for hex format value print. [LLDB] build fix. [LLDB][ExpressionParser] bug fixed for positive int expression e.g. p move +3 to var. [LLDB][TypeSystemLegacy] Fixed bcd signed preferred value encoding. [LLVM][DebuggerTuning] default tune for lldb. [LLDB][TypeSystemLegacy] iconv try approximate and ignore if not possible, for character decoding. rebase build fix. [LLDB][CobolUserExpression][PLIUserExpression] fixed variable name overwriting. [LLDB][UserExpression] Temporary revert variable name bug. rebase build fix. rebase build fix. rebase build fix. initial placeholder for DW_AT_RAINCODE_static_link_recv. [LLDB][CobolUserExpression][PLIUserExpression] fixed variable name overwrite. [LLDB][Test] fixed UnsupportedLanguage test failure. [LLDB][CobolUserExpression] Place holder for compare operations. lldbrpm, temporary skip python dir. [CobolUserExpression] Adding placeholder for equality comparision. [PLIUserExpression] PLILexer, added partial support for comparision operators. [LLDB][DataExtractor] bytes compare func. rebase build fix. rebase build fix. Added DW_AT_RAINCODE_frame_base Patch by Amin! [LLDB][DWARFParser] Added support to parse DW_AT_RAINCODE_frame_base. build fix. [LLVM] Fix dynamic type [LLVM-C][API] Add api to create a dynamic DISubrange [LLDB] Add support for DW_AT_count as a DWARFExpression - Add DWARFExpression in ArrayInfo; - Add LegacyDynamicArray type for dynamic arrays; - Evaluate count expression every time we re-evaluate DW_AT_location. Rebase and fix compilation failures Only print case sensitiveness if source language is Cobol or PL/1. Fixes the following regressions: LLVM :: DebugInfo/X86/dwarf-public-names.ll LLVM :: DebugInfo/X86/length_symbol_difference.ll LLVM :: MC/X86/dwarf-size-field-overflow.test LLVM :: tools/llvm-dwarfdump/X86/statistics.ll (cherry picked from commit ff848081162f81ef3c5d8f447b6c28dd564d4ada) Use correct record size of DIDerivedType Use last index for Annotations replace dyn_cast with dyn_cast_or_null to handle invalid input smoothly Rebasing on LLVM-17-init and fixes regressions LZLANG-2470 valgrind vs. lldb_private::TargetCharsetReader::convert - remove the static buffer_length variable, which may not be big enough. - remove the loop - add lldb console errno logging when there is an iconv error. (cherry picked from commit 120402f28f787a90f65f725307519343b5937fee) LZLANG-2470 Fixes for previous lldb_private::TargetCharsetReader::convert changes. (cherry picked from commit 918c9b62a63b71347ebee5a7ccd0bd42bbdfc118) Lexer Bug Fix COBOL/PLI lexer would return variable name with '\n' at the start. 1155199180 (cherry picked from commit 7266c35747b19a11081b3fab07f6773bfb15fa1f) Ported Abhishek's Fix -Set is_singed for int variables [lldb] Bridge the gap when debugging the variable with command and codelldb (cherry picked from commit d88ad8abed856d239628d4cda3fad393fef1ba0e) Build Fixes after cherry-pick previous commit strings set by codelldb must be enclosed in quotes (cherry picked from commit 0072c09fbe9f5ead6bde25060dc8e9f4265989b3) Bug fix: p var = val in PLI didn't work (cherry picked from commit 9f3d16f85434cbd17e26d429622cd6b557eddacb) Port Abhisheks Fixes -Fix for MOVE val TO VAR [lldb] Added the DemangledNameContainsPath overload for pli/cobol (cherry picked from commit 552cf62d001beb59327e4fb81cd4620ee0d62c55) Fix warnings Fields of a struct array can now be used with `p` e.g FIELD(5) is equivalent to FIELD OF ARR(5) See ticket 1152892604 (cherry picked from commit 5e02341b015fddaca13a674b34228fe2b080a54c) Cobol-style multi-index support added (cherry picked from commit 7b0e7ae494ca2a9799e1f09d87146113de2e0f38) Fixed LENGTH(var) expression -get the size of var from lldb (cherry picked from commit 50657e2e7b2ec81a13764ca0105c130cc95ccfc7) Warning Fixes Make breakpoint Cases Insensitive Fixed Build and Regression failure after rebase Fixed warnings seen during lldb build [lldb] Store real bitwidth from debuginfo in Scalar Type Storing in higher bitwidth than required or specified by debug info creates problem when byteswap is done. Make comparison of breakpoint names case insensitive in `findEntryOffsetInCurrentIndex` 1156642284 typo fix: s/key/Key/ [lldb] Fix DWARFASTParser to correctly parse DW_AT_count for dynamic arrays [lldb] Change the way we look for variables in StackFrame for Legacy Languages 1156032652 [lldb] Bugfix in LENGTH(var) [cobol] and STG(var) [pli] We were encoding 4 bytes of LENGTH data and reading 8 bytes which cause a problem. Using size_t instead of uint32_t fixes the problem. [lldb] Fix cast failure in FindFieldInStructArray Complicated expressions in lldb broke the assumption that the expression is an identifier, thus we got a cast error. This fix removes that from happening and also fixes the bug that if the identifier is an array itself the last index specified in the input is used to index that variable itself. e.g 01 SAMPLE-TABLE. 05 TABLE-DEPTH OCCURS 3 TIMES. 10 TABLE-ROW OCCURS 3 TIMES. 15 TABLE-COLUMN OCCURS 3 TIMES PIC 9(8). Here TABLE-ROW(1, 2) means second element of TABLE-ROW OF TABLE-DEPTH(1). Revert "[lldb] Fix cast failure in FindFieldInStructArray" This reverts commit c1bab0e0b6a798698196434c7bb6cbe391fcdc1b. [lldb] Add support for IBM array-indexing syntax see 1156841764 [lldb] Fix cast error and support non-ibm indexing syntax see 1156841764 [lldb] Fixes After Rebase on llvmorg-18.1.4 [lldb] Fix bug in display of varying PLI strings See 1156884604 The STG function also should include the prefix when counting the size, which for now is 2 bytes for all strings because the PLI compiler doesn't support COMPAT(V3) version. If in the future we do support it, we would need to fix this again. (cherry picked from commit 4b39f3e1b55c3df09f5cb89dcdd347682f790ba9) [lldb] Add basic support for Level88 conditions [lldb] Add support for calling the runtime function rc_cob_level88 directly from the "p" command [lldb] Print the value of level88 variables as true/false with parent name. Prints the value of level88 condition names by calling the runtime functions and formatting it nicely. [lldb] Add support for indexed level88 variables [lldb] Fixes After Rebase on llvm main [LLDB] Preparation for upstream
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Petar Avramovic <[email protected]> Co-authored-by: Piotr Sobczak <[email protected]> [AMDGPU][GFX12] VOP encoding and codegen - add support for v_cvt fp8/… (llvm#78414) …bf8 instructions Add VOP1, VOP1_DPP8, VOP1_DPP16, VOP3, VOP3_DPP8, VOP3_DPP16 instructions that were supported on GFX940 (MI300): - V_CVT_F32_FP8 - V_CVT_F32_BF8 - V_CVT_PK_F32_FP8 - V_CVT_PK_F32_BF8 - V_CVT_PK_FP8_F32 - V_CVT_PK_BF8_F32 - V_CVT_SR_FP8_F32 - V_CVT_SR_BF8_F32 --------- Co-authored-by: Mateja Marjanovic <[email protected]> Co-authored-by: Mirko Brkušanin <[email protected]> (cherry picked from commit cfddb59) [RISCV] Support __riscv_v_fixed_vlen for vbool types. (llvm#76551) This adopts a similar behavior to AArch64 SVE, where bool vectors are represented as a vector of chars with 1/8 the number of elements. This ensures the vector always occupies a power of 2 number of bytes. A consequence of this is that vbool64_t, vbool32_t, and vool16_t can only be used with a vector length that guarantees at least 8 bits. [Docs] Fix documentation build. Missing ending `` after c92ad41 Backport '[clang] static operators should evaluate object argument (reland)' to release/18.x (llvm#80109) Cherry picked from commit ee01a2c. Closes llvm#80041, backport llvm#80108. Co-authored-by: Shafik Yaghmour <[email protected]> Co-authored-by: cor3ntin <[email protected]> Co-authored-by: Aaron Ballman <[email protected]> PR for llvm#79568 (llvm#80120) Backporting llvm#79568 to clang 18. [docs] Add release notes for Windows specific changes in 18.x (llvm#80011) [AArch64] Add some release notes items (llvm#79983) [C++20] [Modules] Don't perform ODR checks in GMF Close llvm#79240. See the linked issue for details. Given the frequency of issue reporting about false positive ODR checks (I received private issue reports too), I'd like to backport this to 18.x too. [clang] Fix unexpected `-Wconstant-logical-operand` in C23 (llvm#80724) C23 has `bool`, but logical operators still return int. Check that we're not in C to avoid false-positive -Wconstant-logical-operand. Fixes llvm#64356 (cherry picked from commit a18e92d) [18.x][Docs] Add release note about Clang-defined target OS macros (llvm#80044) The change is included in the 18.x release. Move the release note to the release branch and reformat. (cherry picked from commit b40d5b1) ReleaseNotes: mention -mtls-dialect=desc (llvm#82731) [Clang] Fixes to immediate-escalating functions (llvm#82281) * Consider that immediate escalating function can appear at global scope, fixing a crash * Lambda conversion to function pointer was sometimes not performed in an immediate function context when it should be. Fixes llvm#82258 (cherry picked from commit baf6bd3) [Clang] [Sema] Handle placeholders in '.*' expressions (llvm#83103) When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]> [InstCombine] Fix miscompilation in PR83947 (llvm#83993) https://github.com/llvm/llvm-project/blob/762f762504967efbe159db5c737154b989afc9bb/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp#L394-L407 Comment from @topperc: > This transforms assumes the mask is a non-zero splat. We only know its a splat and not provably all 0s. The mask is a constexpr that includes the address of the global variable. We can't resolve the constant expression to an exact value. Fixes llvm#83947. SystemZ release notes for 18.x. (llvm#84560) Remove support for EXPORTAS in def files to maintain ABI compatibility for COFFShortExport [clang][Sema] Fix a CTAD regression after 42239d2 (llvm#86914) The most recent declaration of a template as a friend can introduce a different template parameter depth compared to what we anticipate from a CTAD guide. Fixes llvm#86769 [clang] Avoid -Wshadow warning when init-capture named same as class field (llvm#74512) Shadowing warning doesn't make much sense since field is not available in lambda's body without capturing this. Fixes llvm#71976 [SLP]Fix a crash if the argument of call was affected by minbitwidth analysis. Need to support proper type conversion for function arguments to avoid compiler crash. Fix override keyword being print to the left side Previously, the `override` keyword in C++ was being print in the left side of a method decl, which is unsupported by C++ standard. This commit fixes that by setting the `CanPrintOnLeft` field to 0, forcing it to be print on the right side of the decl. Signed-off-by: Giuliano Belinassi <[email protected]> [clang codegen] Fix MS ABI detection of user-provided constructors. (llvm#90151) In the context of determining whether a class counts as an "aggregate", a constructor template counts as a user-provided constructor. Fixes llvm#86384 (cherry picked from commit 3ab4ae9) release/18.x: [libclc] Fix linking against libIRReader Fixes llvm#91551 Update llvm/test/Transforms/InstCombine/bit_ceil.ll Co-authored-by: Yingwei Zheng <[email protected]> [RISCV] Add a unaligned-scalar-mem feature like we had in clang 17. This is ORed with the fast-unaligned-access feature which applies to scalar and vector together.: Regular squash. Cobol/PlI changes from 785ddc60@https://gitlab.phidani.be/Chirag.Patel/lldb.git Cobol/PLI support added from 6cefb217f097ac@https://gitlab.phidani.be/Chirag.Patel/llvm.git [LLDB] added lldb rpmbuild spec file [RPMBuild] Added lldb rpmbuild support. [LLDBRpm] added version for yum update. [lldb_rpm] minor cleanup. Build fix rleated to RTTI. build fix. [DWARFASTParserLegacy] Initial support for union type. [lldb][LegacyTypeSystem] Changed struct/union member offset from bytes to bits to support DW_AT_data_bit_offset. [lldbrpm] changed version suffix. [LegacyASTContext] Fix var string length display. [LLDB][CobolUserExpression] Added AST node Function call place holder. build fix. [LLVM][Test] Fixed assembler round trip test. [LLDB][CobolUserExpression] Added ast evaluation for sizeof operator. [LLDB][CobolUserExpression] Added placeholder in parser for func call. [LLDB][CobolUserExpression] Added sizeof operator, temporary placeholder for LENGTH OF. [LLDB][PLIUserExpression] Fixed array indexing. [LLDB][ValueObjectPrinter] Skip summary if custom format is requested. [LLDB][PLILanguage] changed bitset size, read from array type name. [LLDB][ValueObject] Fixed pli var string length read. [LLDB][PLILanguage] Fixed support for var string summary formatter. [LLVM][DIBuilder][C-API] Added changes to add lexical scope info for auto variable for functions. [LLVM][AsmCodegen] Added raincode extention AT_lexical_scope. [LLDB][SymbolFileDWARF] Added support for RAINCODE_lexical_scope attribute. [LLDB][PLIUserExpression] Added sizeof operator support, it will be renamed to proper functiona name later. [LLDB][ValueObject] minor cleanup. [LLDB][PLIUserExpression] Added STORAGE/STG builtin func support. [LLDB][PLIUserExpression][CobolUserExpression] Added LENGTH() for Cobol and STG/STORAGE() for PL/I, removed sizeof operator for both. [LLDB][DWARFASTParserLegacy] Added placeholder for DW_TAG_reference_type. [LLVM][CodeGen][AsmPrinter] Added DW_AT_name attribute to TAG_array_type. [LLDB][DWARFExpression] minor cleanup. [LLDB][PLILanguage] Fixed bitset array size read from array type. [LLDB][LegacyASTContext] Moved bit array calculation to type system. [LLVM][AsmPrinter] Fixed TAG_array duplicate attribute export. [LLVM][C-API] Changes array type api. [LLDB][PLI/Cobol UserExpression] Fixed array indexing, removed c style [] index access. [LLDB][PLIUserExpression] minor fix. [LLDB] Fixed bug relating struct member name access for Cobol/PL1. fixed coding style/whitespace/typos. [LLDB][LegacyTypeSystem] Place holder beautification for edited types. [LLDB] rpm version upgrade. [LLDB][CobolUserExpression] Fixed pic string ref modifier. [LLDB][TypeSystem] Added support to mutate existing type length, fixed cobolUserExpression refmod for display type. [LLDB][CobolUserExpression] Fixed lower bound ref modifier. [LLDB][Cobol/PLI UserExpression] Fixed error while searching for var, do not fully resolve type. [LLDB][RPM] fixed rpm version. cleanup, reduce number of changes from trunk. cleanup, reduce number of changes fomr trunk. build fix. Build fix. Build fix. [LegacyASTContext] Fixed bug relating packed decimal going through ebcdic iconv. [LLVM][DebugInfo] Fixed DIExpression node uniquness issue. build fix. cleanup. Refactoring, moved LegacyASTContext to Plugin typeSystem Legacy. Refactoring, renamed TypeSystem class. build fix. build fix, cleanup. cleanup fixed assert failure. [CobolUserExpression] Added placeholder for simpe assignment operator. [CobolUserExpression] Added basic support for assigment to variables. [CobolUserExpression] Added cobol move-to set-to syntex support. [LegacyTypeSystem][CobolUserExpression] Added literal type double,string. Added TypeSystem Encoding helper functions. [CobolLexer] Added string,float literal type support. [PLIUserExpression] Added assignment operator support. [CobolUserExpression] Added assignment comp-3 support. [PLIUserExpression] Assignment added pli display type support. temporary build fix. DIExpression asmprinter, print null for invalid entry. [Cobol/PLI UserExpression] Assignment endianity bug fix. [Cobol/PLIUserExpression] fixed data extractpr assert, fixed int precision convertion written as zero. [Cobol/PLIUserExpression] Assignment display type assert failure. build fix. [PLIUserExpression] Added support for var string assignment. [LegacyUserExpression] Simple semantic check place-holder. [CobolUserexpression] Assignment expression fixed display, array types. [TypeSystem] fixed encode int precision bug for i64 to i32. [PLI/Cobol UserExpression] fixed support for assinment into refmod data type. [CobolUserExpression] Fixed assignment display/comp-3 regression. temporary build fix. python3 lib on server needs few changes for this build. [TypeSystemLegacy] Fixed edited type display, skip formatting for edited type. [lldbrpm] package lldb-python-script too. [CobolUserExpression] Fixed SelctorOf expression with array index access e.g (lldb)p LastName1 of VAR(1) of TAB. [CobolUserExpression] Assignment to packed decimal fixed, added digit count read support from dwarf instead of runtime calculation. [CoboUserExpression] Fixed assignment string invalid byte order. [PLIUserExpression] Fixed string padding with space. [CobolUserExpression] Fixed Assignment string space padding. [LegacyTypeSysten] fixed crash in encoding due to long length the assignment. [CobolUserExpression][PLIUserExpression] fixed segfault. [DebugInfo] export identifier case as insensitive for PLI/Cobol compiled units. [TypeSystemLegacy] Fixed minor bug with dataencoding. rebase build fix. [StackFrame] fixed support for cobol/pli modref select syntex. case-insensitive breakpoint resolution for PLI/Cobol languages. cleanup. build fix. added initial support for TAG_dynamic_type. added c/c++ api to create dynamic type debug info. [DebugInfo] Added support to generate dwarf attribute DW_AT_allocated for DW_TAG_dynamic_type [PLIUserExpression][CobolUserExpression] Fixed name variable lookup for few cases. [DWARFASTParserLegacy] Initial support to parse TAG_dynamic_type. [AsmPrinter] Fix minor mistake for TAG_dynamic DW_AT_allocated. [TypeSystemLegacy] Added dynamic type place holder. [LLVM][AsmPrinter] Allow OP_call2/4 expression on local variable location. build fix. [LLDB][CompilerType] Added support to fetch dynamic type info. [lldb][ValueObjectVariable] Added dynamic variable read support. [LLDB][ValueObjectVariable] Added allocated check for dynamic types. [LLDB][ValueObjectVariable] fixed TAG_dynamic type attributes optional. [LLVM][DebugInfoMetadata] Fixed minor function call. [LLDB][TypeSystemLegacy] Added dynamic type info support. build fix. for jekins, use python3 sharedlibs lldbrpm use python3. temporary build fix. [LLDB][DWARFExpression] Added temporary operation extension for address calculation with file address in dwarf v5. [LLVM][CodeGen] Fixed dynamic type dwarf expression call2/call4 assert. [LLVM][Verifier] Added dynamic type check. [LLVM][Verifier] Added debugInfo verifier dynamic type extra checks. [LLDB][TypeSystemLegacy] Added check to avoid direct nested dynaic types. [LLVM][DebugInfo] Adding DW_OP_call2/4 support in TAG_subrange attributes DW_AT_lower_bound, DW_AT_upper_bound. [LLDB] Added option to hide frames with invalid line entry target.hide-invalid-legacy-frames, this is a temporary placeholder and it will be moved to more suitable location in future. [LLDB][DataFormatters] Fixed printing of char arrays with non-default format. [LLDB][StackFrame] Added check for member name lookup to reject array of structs. [lldb][DataFormatters] fixed multi-dimesional string formatting. [LLDB][ValueObjectVariable] cleanup: proper error message. [LLVM][DwarfUnit] Added DW_OP_call2/call4 support for array type. [LLVM][DwarfCompileUnit] fixed assert failure with DW_OP_call2/call4. [DIBuilder] Added DW_AT_static_link support. [LLVM][C-API][DebugInfo] Added support for DW_AT_static_link. [DebugInfo] fixed minor bug with Staticlink attribute generation. [DebugInfo] static link cleanup. rebase build fix. [LLDB][DWARFParser] Added initial support to parse DW_AT_static_link. [LLDB][StackFrame] Added support to read static link address. [LLDB][StackFrameList] Added helper function to search stack list using static link. [LLDB][ValueObjectPrinter] regression fix for hex format value print. [LLDB] build fix. [LLDB][ExpressionParser] bug fixed for positive int expression e.g. p move +3 to var. [LLDB][TypeSystemLegacy] Fixed bcd signed preferred value encoding. [LLVM][DebuggerTuning] default tune for lldb. [LLDB][TypeSystemLegacy] iconv try approximate and ignore if not possible, for character decoding. rebase build fix. [LLDB][CobolUserExpression][PLIUserExpression] fixed variable name overwriting. [LLDB][UserExpression] Temporary revert variable name bug. rebase build fix. rebase build fix. rebase build fix. initial placeholder for DW_AT_RAINCODE_static_link_recv. [LLDB][CobolUserExpression][PLIUserExpression] fixed variable name overwrite. [LLDB][Test] fixed UnsupportedLanguage test failure. [LLDB][CobolUserExpression] Place holder for compare operations. lldbrpm, temporary skip python dir. [CobolUserExpression] Adding placeholder for equality comparision. [PLIUserExpression] PLILexer, added partial support for comparision operators. [LLDB][DataExtractor] bytes compare func. rebase build fix. rebase build fix. Added DW_AT_RAINCODE_frame_base Patch by Amin! [LLDB][DWARFParser] Added support to parse DW_AT_RAINCODE_frame_base. build fix. [LLVM] Fix dynamic type [LLVM-C][API] Add api to create a dynamic DISubrange [LLDB] Add support for DW_AT_count as a DWARFExpression - Add DWARFExpression in ArrayInfo; - Add LegacyDynamicArray type for dynamic arrays; - Evaluate count expression every time we re-evaluate DW_AT_location. Rebase and fix compilation failures Only print case sensitiveness if source language is Cobol or PL/1. Fixes the following regressions: LLVM :: DebugInfo/X86/dwarf-public-names.ll LLVM :: DebugInfo/X86/length_symbol_difference.ll LLVM :: MC/X86/dwarf-size-field-overflow.test LLVM :: tools/llvm-dwarfdump/X86/statistics.ll (cherry picked from commit ff848081162f81ef3c5d8f447b6c28dd564d4ada) Use correct record size of DIDerivedType Use last index for Annotations replace dyn_cast with dyn_cast_or_null to handle invalid input smoothly Rebasing on LLVM-17-init and fixes regressions LZLANG-2470 valgrind vs. lldb_private::TargetCharsetReader::convert - remove the static buffer_length variable, which may not be big enough. - remove the loop - add lldb console errno logging when there is an iconv error. (cherry picked from commit 120402f28f787a90f65f725307519343b5937fee) LZLANG-2470 Fixes for previous lldb_private::TargetCharsetReader::convert changes. (cherry picked from commit 918c9b62a63b71347ebee5a7ccd0bd42bbdfc118) Lexer Bug Fix COBOL/PLI lexer would return variable name with '\n' at the start. 1155199180 (cherry picked from commit 7266c35747b19a11081b3fab07f6773bfb15fa1f) Ported Abhishek's Fix -Set is_singed for int variables [lldb] Bridge the gap when debugging the variable with command and codelldb (cherry picked from commit d88ad8abed856d239628d4cda3fad393fef1ba0e) Build Fixes after cherry-pick previous commit strings set by codelldb must be enclosed in quotes (cherry picked from commit 0072c09fbe9f5ead6bde25060dc8e9f4265989b3) Bug fix: p var = val in PLI didn't work (cherry picked from commit 9f3d16f85434cbd17e26d429622cd6b557eddacb) Port Abhisheks Fixes -Fix for MOVE val TO VAR [lldb] Added the DemangledNameContainsPath overload for pli/cobol (cherry picked from commit 552cf62d001beb59327e4fb81cd4620ee0d62c55) Fix warnings Fields of a struct array can now be used with `p` e.g FIELD(5) is equivalent to FIELD OF ARR(5) See ticket 1152892604 (cherry picked from commit 5e02341b015fddaca13a674b34228fe2b080a54c) Cobol-style multi-index support added (cherry picked from commit 7b0e7ae494ca2a9799e1f09d87146113de2e0f38) Fixed LENGTH(var) expression -get the size of var from lldb (cherry picked from commit 50657e2e7b2ec81a13764ca0105c130cc95ccfc7) Warning Fixes Make breakpoint Cases Insensitive Fixed Build and Regression failure after rebase Fixed warnings seen during lldb build [lldb] Store real bitwidth from debuginfo in Scalar Type Storing in higher bitwidth than required or specified by debug info creates problem when byteswap is done. Make comparison of breakpoint names case insensitive in `findEntryOffsetInCurrentIndex` 1156642284 typo fix: s/key/Key/ [lldb] Fix DWARFASTParser to correctly parse DW_AT_count for dynamic arrays [lldb] Change the way we look for variables in StackFrame for Legacy Languages 1156032652 [lldb] Bugfix in LENGTH(var) [cobol] and STG(var) [pli] We were encoding 4 bytes of LENGTH data and reading 8 bytes which cause a problem. Using size_t instead of uint32_t fixes the problem. [lldb] Fix cast failure in FindFieldInStructArray Complicated expressions in lldb broke the assumption that the expression is an identifier, thus we got a cast error. This fix removes that from happening and also fixes the bug that if the identifier is an array itself the last index specified in the input is used to index that variable itself. e.g 01 SAMPLE-TABLE. 05 TABLE-DEPTH OCCURS 3 TIMES. 10 TABLE-ROW OCCURS 3 TIMES. 15 TABLE-COLUMN OCCURS 3 TIMES PIC 9(8). Here TABLE-ROW(1, 2) means second element of TABLE-ROW OF TABLE-DEPTH(1). Revert "[lldb] Fix cast failure in FindFieldInStructArray" This reverts commit c1bab0e0b6a798698196434c7bb6cbe391fcdc1b. [lldb] Add support for IBM array-indexing syntax see 1156841764 [lldb] Fix cast error and support non-ibm indexing syntax see 1156841764 [lldb] Fixes After Rebase on llvmorg-18.1.4 [lldb] Fix bug in display of varying PLI strings See 1156884604 The STG function also should include the prefix when counting the size, which for now is 2 bytes for all strings because the PLI compiler doesn't support COMPAT(V3) version. If in the future we do support it, we would need to fix this again. (cherry picked from commit 4b39f3e1b55c3df09f5cb89dcdd347682f790ba9) [lldb] Add basic support for Level88 conditions [lldb] Add support for calling the runtime function rc_cob_level88 directly from the "p" command [lldb] Print the value of level88 variables as true/false with parent name. Prints the value of level88 condition names by calling the runtime functions and formatting it nicely. [lldb] Add support for indexed level88 variables [lldb] Fixes After Rebase on llvm main [LLDB] Preparation for upstream
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Oct 10, 2024
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling `checkPlaceholderForOverload()`, which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution. Unfortunately, we were also doing that for `.*`, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion in `CreateBuiltinBinOp()`—specifically, in one of its callees—in the `.*` case that makes sure its arguments aren’t placeholders). This pr instead makes it so we check for *all* placeholders early if the operator is `.*`. It’s worth noting that, 1. In the `.*` case, we now additionally also check for *any* placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of `.*`; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though. 2. There is another case in which we also don’t perform overload resolution—namely `=` if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the `.*` case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly, `CreateBuiltinBinOp()` doesn’t seem to care about placeholders in the LHS or RHS in the `=` case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call to `checkPlaceholderForOverload()` by the time we get to this function), so I don’t think this case suffers from the same problem. This fixes llvm#53815. --------- Co-authored-by: Aaron Ballman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When analysing whether we should handle a binary expression as an overloaded operator call or a builtin operator, we were calling
checkPlaceholderForOverload(), which takes care of any placeholders that are not overload sets—which would usually make sense since those need to be handled as part of overload resolution.Unfortunately, we were also doing that for
.*, which is not overloadable, and then proceeding to create a builtin operator anyway, which would crash if the RHS happened to be an unresolved overload set (due hitting an assertion inCreateBuiltinBinOp()—specifically, in one of its callees—in the.*case that makes sure its arguments aren’t placeholders).This pr instead makes it so we check for all placeholders early if the operator is
.*.It’s worth noting that,
.*case, we now additionally also check for any placeholders (not just non-overload-sets) in the LHS; this shouldn’t make a difference, however—at least I couldn’t think of a way to trigger the assertion with an overload set as the LHS of.*; it is worth noting that the assertion in question would also complain if the LHS happened to be of placeholder type, though.=if the LHS is not of class or enumeration type after handling non-overload-set placeholders—as in the.*case, but similarly to 1., I first couldn’t think of a way of getting this case to crash, and secondly,CreateBuiltinBinOp()doesn’t seem to care about placeholders in the LHS or RHS in the=case (from what I can tell, it, or rather one of its callees, only checks that the LHS is not a pseudo-object type, but those will have already been handled by the call tocheckPlaceholderForOverload()by the time we get to this function), so I don’t think this case suffers from the same problem.This fixes #53815.