Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DirectX] Replace loads from cbufs with cbufferLoad #75830

Closed
bogner opened this issue Dec 18, 2023 · 1 comment
Closed

[DirectX] Replace loads from cbufs with cbufferLoad #75830

bogner opened this issue Dec 18, 2023 · 1 comment
Labels
backend:DirectX obsolete Issues with old (unsupported) versions of LLVM

Comments

@bogner
Copy link
Contributor

bogner commented Dec 18, 2023

In order to generate correct dxil for cbuffers, we'll need to walk through the hlsl.cbufs metadata and replace memory accesses to those globals with accesses via cbufferLoad.

See https://reviews.llvm.org/D131370 for one approach to this.

@bogner
Copy link
Contributor Author

bogner commented Aug 27, 2024

This no longer really makes sense as is. We'll use target extension types and intrinsics to represent cbuffer loads throughout the pipeline. See llvm/wg-hlsl#50 for details.

@bogner bogner closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
@EugeneZelenko EugeneZelenko added the obsolete Issues with old (unsupported) versions of LLVM label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX obsolete Issues with old (unsupported) versions of LLVM
Projects
Status: No status
Development

No branches or pull requests

2 participants