Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport a84525233776a716e2c6291993f0b33fd1c76f7c (Wrong -Wconstant-logical-operand warning) #64515

Closed
xgupta opened this issue Aug 8, 2023 · 5 comments · Fixed by llvm/llvm-project-release-prs#546
Closed

backport a84525233776a716e2c6291993f0b33fd1c76f7c (Wrong -Wconstant-logical-operand warning) #64515

xgupta opened this issue Aug 8, 2023 · 5 comments · Fixed by llvm/llvm-project-release-prs#546
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer release:backport release:merged
Milestone
LLVM 17.0.X Release

Comments

@xgupta
Copy link
Contributor

xgupta commented Aug 8, 2023

/cherry-pick a845252

Issue has been raised to revert this commit because of the wrong warning - #64356.
@llvmbot
Copy link
Collaborator

llvmbot commented Aug 8, 2023

/cherry-pick a845252

Issue has been raised to revert this commit because of the wrong warning - #64356.

Error: Command failed due to missing milestone.

@xgupta xgupta added this to the LLVM 17.0.X Release milestone Aug 8, 2023
@brad0
Copy link
Contributor

brad0 commented Aug 8, 2023

/cherry-pick a845252

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 8, 2023

Failed to cherry-pick: a845252

https://github.com/llvm/llvm-project/actions/runs/5792298326

Please manually backport the fix and push it to your github fork. Once this is done, please add a comment like this:

/branch <user>/<repo>/<branch>

@EugeneZelenko EugeneZelenko added the clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer label Aug 8, 2023
@xgupta
Copy link
Contributor Author

xgupta commented Aug 8, 2023

/branch xgupta/llvm-project/release/17.x

@llvmbot llvmbot mentioned this issue Aug 8, 2023
Merged
@llvmbot
Copy link
Collaborator

llvmbot commented Aug 8, 2023

/pull-request llvm/llvm-project-release-prs#546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer release:backport release:merged
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#64515 llvm/llvm-project-release-prs
4 participants
@brad0 @EugeneZelenko @llvmbot @xgupta