Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off string tail merging by default in lld-link? #62632

Open
amykhuang opened this issue May 9, 2023 · 2 comments
Open

turn off string tail merging by default in lld-link? #62632

amykhuang opened this issue May 9, 2023 · 2 comments
Labels

Comments

@amykhuang
Copy link
Collaborator

Recently I found that string tail merging causes an ASan false positive crashes on Windows (#62078). This crash came up in gtest code, and I assume it would not be too difficult to run into.

Chromium also disables string tail merging because it increases compressed binary size (crbug.com/838449).

Currently string tail merging is on by default when ICF is on. Given these issues, does it make sense to disable string tail merging by default?

@llvmbot
Copy link
Collaborator

llvmbot commented May 9, 2023

@llvm/issue-subscribers-lld-coff

@rnk
Copy link
Collaborator

rnk commented May 9, 2023

+1, I think it would make sense to make string tail merging its own feature.

From a high level, ASan should ideally just work out of the box without magic linker flags like /opt:nolldtailmerge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants