Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerPC] SCV system call instruction missing #60520

Closed
edelsohn opened this issue Feb 3, 2023 · 6 comments
Closed

[PowerPC] SCV system call instruction missing #60520

edelsohn opened this issue Feb 3, 2023 · 6 comments
Assignees

Comments

@edelsohn
Copy link

edelsohn commented Feb 3, 2023

PPCInstrInfo.td defines the original SC system call instruction. The SCV system call instruction added in Power9 is not defined or available. The missing Power9 instruction is not mentioned in the README_P9.txt file of improvements.

The inability of Clang to recognize the SCV instruction in inline assembly prevents Clang from compiling some common Linux tools and packages, such as Valgrind.

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 3, 2023

@llvm/issue-subscribers-backend-powerpc

@edelsohn
Copy link
Author

edelsohn commented Feb 3, 2023

@tstellar FYI

@stefanp-ibm
Copy link
Contributor

I've put up a quick patch for this: #68063

@stefanp-ibm stefanp-ibm self-assigned this Oct 3, 2023
@stefanp-ibm
Copy link
Contributor

This patch has now gone in:

commit 23e7da8f106e173f6efeaf7b791418b9494ac10c
Author: Stefan Pintilie <[email protected]>
Date:   Thu Oct 5 12:51:04 2023 -0400

    [PowerPC] Add the SCV instruction. (#68063)
    
    The SCV instruciton was added on PowerPC on Power 9. This patch adds the
    SCV so that it may be used as part of inline asm but does not provide
    patterns for it or scheduling information.
    
    Co-authored-by: Stefan Pintilie <[email protected]>

@stefanp-ibm
Copy link
Contributor

@edelsohn
I believe that the fix has gone in at this point. Can this issue be closed?

@edelsohn
Copy link
Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants