clang: Assertion `Ex->getType()->isAggregateType() && "Other kinds of expressions with non-aggregate types do not " "have lvalues."' failed

[edwintorok]

Bugzilla Link	2948
Resolution	FIXED
Resolved on	Feb 22, 2010 12:49
Version	unspecified
OS	Linux
CC	@tkremenek

Extended Description

Using SVN r58134:

$ clang -checker-simple testcase-min.i
ANALYZE: testcase-min.i checkaccess
clang: GRExprEngine.cpp:455: void clang::GRExprEngine::VisitLValue(clang::Expr*, clang::ExplodedNodeclang::GRState*, clang::ExplodedNodeSetclang::GRState&): Assertion `Ex->getType()->isAggregateType() && "Other kinds of expressions with non-aggregate types do not " "have lvalues."' failed.
clang[0xd0eeef]
/lib/libc.so.6[0x7f1870e83f60]
/lib/libc.so.6(gsignal+0x35)[0x7f1870e83ed5]
/lib/libc.so.6(abort+0x183)[0x7f1870e853f3]
/lib/libc.so.6(__assert_fail+0xe9)[0x7f1870e7cdc9]
clang(_ZN5clang12GRExprEngine11VisitLValueEPNS_4ExprEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EE+0x270)[0x7be250]
clang(_ZN5clang12GRExprEngine15VisitMemberExprEPNS_10MemberExprEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EEb+0x89)[0x7be349]
clang(_ZN5clang12GRExprEngine5VisitEPNS_4StmtEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EE+0x25e)[0x7bbfbe]
clang(_ZN5clang12GRExprEngine18VisitUnaryOperatorEPNS_13UnaryOperatorEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EEb+0x418)[0x7beb28]
clang(_ZN5clang12GRExprEngine5VisitEPNS_4StmtEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EE+0x1c7)[0x7bbf27]
clang(_ZN5clang12GRExprEngine19VisitBinaryOperatorEPNS_14BinaryOperatorEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EE+0xbb)[0x7bab3b]
clang(_ZN5clang12GRExprEngine5VisitEPNS_4StmtEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EE+0x307)[0x7bc067]
clang(_ZN5clang12GRExprEngine19VisitBinaryOperatorEPNS_14BinaryOperatorEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EE+0xbb)[0x7bab3b]
clang(_ZN5clang12GRExprEngine5VisitEPNS_4StmtEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EE+0x307)[0x7bc067]
clang(_ZN5clang12GRExprEngine19VisitBinaryOperatorEPNS_14BinaryOperatorEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EE+0xbb)[0x7bab3b]
clang(_ZN5clang12GRExprEngine5VisitEPNS_4StmtEPNS_12ExplodedNodeINS_7GRStateEEERNS_15ExplodedNodeSetIS4_EE+0x307)[0x7bc067]
clang(_ZN5clang12GRExprEngine11ProcessStmtEPNS_4StmtERNS_17GRStmtNodeBuilderINS_7GRStateEEE+0x19b)[0x7c07ab]
clang(_ZN5clang12GRCoreEngineINS_12GRExprEngineEE11ProcessStmtEPNS_4StmtERNS_21GRStmtNodeBuilderImplE+0x55)[0x7c6f45]
clang(_ZN5clang16GRCoreEngineImpl14HandlePostStmtERKNS_8PostStmtEPNS_8CFGBlockEjPNS_16ExplodedNodeImplE+0xcd)[0x7b558d]
clang(_ZN5clang16GRCoreEngineImpl15ExecuteWorkListEj+0x256)[0x7b5ae6]
clang(tan+0x5be9)[0x550a59]
clang[0x5524fd]
clang[0x552817]
clang(_ZN5clang8ParseASTERNS_12PreprocessorEPNS_11ASTConsumerEbb+0x146)[0x7f33f6]
clang[0x578249]
clang(main+0x594)[0x57cad4]
/lib/libc.so.6(__libc_start_main+0xe6)[0x7f1870e701a6]
clang(_ZNSt8ios_base4InitD1Ev+0x39)[0x54b9b9]
Aborted

[edwintorok]

assigned to @tkremenek

[edwintorok]

/* testcase */
int
checkaccess ()
{
int ret = 0, status;
if (((((extension (((union
{
__typeof (status) __in; int __i;}
)
{
.__in = (status)}
).__i))) & 0xff00) >> 8) == 1)
ret = 1;
}

[tkremenek]

/* testcase */
int
checkaccess ()
{
int ret = 0, status;
if (((((extension (((union
{
__typeof (status) __in; int __i;}
)
{
.__in = (status)}
).__i))) & 0xff00) >> 8) == 1)
ret = 1;
}

The assertion occurs on the following expression:

(CompoundLiteralExpr 0x20086f0 'union '
(InitListExpr 0x20086c0 'union '
(ParenExpr 0x20086a0 'int'
(DeclRefExpr 0x2008680 'int' Var='status' 0x20084c0))))

Apparently anonymous unions return false of isAggregateType().

[tkremenek]

Fixed: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20081020/008556.html