fix symbols issue

Author: j2kun

mlir/lib/Analysis/Presburger/IntegerRelation.cpp

@@ -2490,12 +2490,6 @@ IntegerRelation IntegerRelation::rangeProduct(const IntegerRelation &rel) {
 
   // explicit copy of `this`
   IntegerRelation result = *this;
-
-  // An explicit copy of `rel` is needed to merge and align symbols, since that
-  // function mutates both relations.
-  IntegerRelation relCopy = rel;
-  result.mergeAndAlignSymbols(relCopy);
-
   unsigned relRangeVarStart = rel.getVarKindOffset(VarKind::Range);
   unsigned numThisRangeVars = getNumRangeVars();
   unsigned numNewSymbolVars = result.getNumSymbolVars() - getNumSymbolVars();

mlir/unittests/Analysis/Presburger/IntegerRelationTest.cpp

@@ -692,11 +692,11 @@ TEST(IntegerRelationTest, rangeProductSymbols) {
   IntegerRelation r1 = parseRelationFromSet(
       "(i, j)[s] : (2*i + 3*j + s == 0, i >= 0, j >= 0)", 1);
   IntegerRelation r2 = parseRelationFromSet(
-      "(i, l)[t] : (3*i + 4*l + t == 0, i >= 0, l >= 0)", 1);
+      "(i, l)[s] : (3*i + 4*l + s == 0, i >= 0, l >= 0)", 1);
 
   IntegerRelation rangeProd = r1.rangeProduct(r2);
   IntegerRelation expected = parseRelationFromSet(
-      "(i, j, k, l)[s, t] : (2*i + 3*j + s == 0, 3*i + 4*l + t == "
+      "(i, j, l)[s] : (2*i + 3*j + s == 0, 3*i + 4*l + s == "
       "0, i >= 0, j >= 0, l >= 0)",
       1);