From b3b3336e82763d8c216c1dacf4d7c60c8513db0d Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Fri, 6 Oct 2023 20:57:58 +0800 Subject: [PATCH] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (#65852) This patch folds the pattern `a ne/eq (zext/sext (a ne/eq c))` into a boolean constant or a compare. Clang vs GCC: https://godbolt.org/z/4ro817WE8 Proof for `zext`: https://alive2.llvm.org/ce/z/6z9NRF Proof for `sext`: https://alive2.llvm.org/ce/z/tv5wuE Fixes #65073. --- .../InstCombine/InstCombineCompares.cpp | 67 +++++ .../test/Transforms/InstCombine/icmp-range.ll | 256 ++++++++++-------- 2 files changed, 209 insertions(+), 114 deletions(-) diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp index 8e314ddd972f37..95b506f0e35faf 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp @@ -6481,6 +6481,73 @@ Instruction *InstCombinerImpl::foldICmpUsingBoolRange(ICmpInst &I) { Y->getType()->isIntOrIntVectorTy(1) && Pred == ICmpInst::ICMP_ULE) return BinaryOperator::CreateOr(Builder.CreateIsNull(X), Y); + // icmp eq/ne X, (zext/sext (icmp eq/ne X, C)) + ICmpInst::Predicate Pred1, Pred2; + const APInt *C; + Instruction *ExtI; + if (match(&I, m_c_ICmp(Pred1, m_Value(X), + m_CombineAnd(m_Instruction(ExtI), + m_ZExtOrSExt(m_ICmp(Pred2, m_Deferred(X), + m_APInt(C)))))) && + ICmpInst::isEquality(Pred1) && ICmpInst::isEquality(Pred2)) { + bool IsSExt = ExtI->getOpcode() == Instruction::SExt; + bool HasOneUse = ExtI->hasOneUse() && ExtI->getOperand(0)->hasOneUse(); + auto CreateRangeCheck = [&] { + Value *CmpV1 = + Builder.CreateICmp(Pred1, X, Constant::getNullValue(X->getType())); + Value *CmpV2 = Builder.CreateICmp( + Pred1, X, ConstantInt::getSigned(X->getType(), IsSExt ? -1 : 1)); + return BinaryOperator::Create( + Pred1 == ICmpInst::ICMP_EQ ? Instruction::Or : Instruction::And, + CmpV1, CmpV2); + }; + if (C->isZero()) { + if (Pred2 == ICmpInst::ICMP_EQ) { + // icmp eq X, (zext/sext (icmp eq X, 0)) --> false + // icmp ne X, (zext/sext (icmp eq X, 0)) --> true + return replaceInstUsesWith( + I, ConstantInt::getBool(I.getType(), Pred1 == ICmpInst::ICMP_NE)); + } else if (!IsSExt || HasOneUse) { + // icmp eq X, (zext (icmp ne X, 0)) --> X == 0 || X == 1 + // icmp ne X, (zext (icmp ne X, 0)) --> X != 0 && X != 1 + // icmp eq X, (sext (icmp ne X, 0)) --> X == 0 || X == -1 + // icmp ne X, (sext (icmp ne X, 0)) --> X != 0 && X == -1 + return CreateRangeCheck(); + } + } else if (IsSExt ? C->isAllOnes() : C->isOne()) { + if (Pred2 == ICmpInst::ICMP_NE) { + // icmp eq X, (zext (icmp ne X, 1)) --> false + // icmp ne X, (zext (icmp ne X, 1)) --> true + // icmp eq X, (sext (icmp ne X, -1)) --> false + // icmp ne X, (sext (icmp ne X, -1)) --> true + return replaceInstUsesWith( + I, ConstantInt::getBool(I.getType(), Pred1 == ICmpInst::ICMP_NE)); + } else if (!IsSExt || HasOneUse) { + // icmp eq X, (zext (icmp eq X, 1)) --> X == 0 || X == 1 + // icmp ne X, (zext (icmp eq X, 1)) --> X != 0 && X != 1 + // icmp eq X, (sext (icmp eq X, -1)) --> X == 0 || X == -1 + // icmp ne X, (sext (icmp eq X, -1)) --> X != 0 && X == -1 + return CreateRangeCheck(); + } + } else { + // when C != 0 && C != 1: + // icmp eq X, (zext (icmp eq X, C)) --> icmp eq X, 0 + // icmp eq X, (zext (icmp ne X, C)) --> icmp eq X, 1 + // icmp ne X, (zext (icmp eq X, C)) --> icmp ne X, 0 + // icmp ne X, (zext (icmp ne X, C)) --> icmp ne X, 1 + // when C != 0 && C != -1: + // icmp eq X, (sext (icmp eq X, C)) --> icmp eq X, 0 + // icmp eq X, (sext (icmp ne X, C)) --> icmp eq X, -1 + // icmp ne X, (sext (icmp eq X, C)) --> icmp ne X, 0 + // icmp ne X, (sext (icmp ne X, C)) --> icmp ne X, -1 + return ICmpInst::Create( + Instruction::ICmp, Pred1, X, + ConstantInt::getSigned(X->getType(), Pred2 == ICmpInst::ICMP_NE + ? (IsSExt ? -1 : 1) + : 0)); + } + } + return nullptr; } diff --git a/llvm/test/Transforms/InstCombine/icmp-range.ll b/llvm/test/Transforms/InstCombine/icmp-range.ll index a6b629373946e3..7af06e03fd4b2a 100644 --- a/llvm/test/Transforms/InstCombine/icmp-range.ll +++ b/llvm/test/Transforms/InstCombine/icmp-range.ll @@ -1037,10 +1037,7 @@ define i1 @icmp_ne_bool_1(ptr %ptr) { ; Tests from PR65073 define i1 @icmp_ne_zext_eq_zero(i32 %a) { ; CHECK-LABEL: @icmp_ne_zext_eq_zero( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 0 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] -; CHECK-NEXT: ret i1 [[CMP1]] +; CHECK-NEXT: ret i1 true ; %cmp = icmp eq i32 %a, 0 %conv = zext i1 %cmp to i32 @@ -1050,9 +1047,7 @@ define i1 @icmp_ne_zext_eq_zero(i32 %a) { define i1 @icmp_ne_zext_ne_zero(i32 %a) { ; CHECK-LABEL: @icmp_ne_zext_ne_zero( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 0 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt i32 [[A:%.*]], 1 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp ne i32 %a, 0 @@ -1063,10 +1058,7 @@ define i1 @icmp_ne_zext_ne_zero(i32 %a) { define i1 @icmp_eq_zext_eq_zero(i32 %a) { ; CHECK-LABEL: @icmp_eq_zext_eq_zero( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 0 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] -; CHECK-NEXT: ret i1 [[CMP1]] +; CHECK-NEXT: ret i1 false ; %cmp = icmp eq i32 %a, 0 %conv = zext i1 %cmp to i32 @@ -1076,9 +1068,7 @@ define i1 @icmp_eq_zext_eq_zero(i32 %a) { define i1 @icmp_eq_zext_ne_zero(i32 %a) { ; CHECK-LABEL: @icmp_eq_zext_ne_zero( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 0 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[A:%.*]], 2 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp ne i32 %a, 0 @@ -1089,9 +1079,7 @@ define i1 @icmp_eq_zext_ne_zero(i32 %a) { define i1 @icmp_ne_zext_eq_one(i32 %a) { ; CHECK-LABEL: @icmp_ne_zext_eq_one( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 1 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt i32 [[A:%.*]], 1 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp eq i32 %a, 1 @@ -1102,10 +1090,7 @@ define i1 @icmp_ne_zext_eq_one(i32 %a) { define i1 @icmp_ne_zext_ne_one(i32 %a) { ; CHECK-LABEL: @icmp_ne_zext_ne_one( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 1 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] -; CHECK-NEXT: ret i1 [[CMP1]] +; CHECK-NEXT: ret i1 true ; %cmp = icmp ne i32 %a, 1 %conv = zext i1 %cmp to i32 @@ -1115,9 +1100,7 @@ define i1 @icmp_ne_zext_ne_one(i32 %a) { define i1 @icmp_eq_zext_eq_one(i32 %a) { ; CHECK-LABEL: @icmp_eq_zext_eq_one( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 1 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[A:%.*]], 2 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp eq i32 %a, 1 @@ -1128,10 +1111,7 @@ define i1 @icmp_eq_zext_eq_one(i32 %a) { define i1 @icmp_eq_zext_ne_one(i32 %a) { ; CHECK-LABEL: @icmp_eq_zext_ne_one( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 1 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] -; CHECK-NEXT: ret i1 [[CMP1]] +; CHECK-NEXT: ret i1 false ; %cmp = icmp ne i32 %a, 1 %conv = zext i1 %cmp to i32 @@ -1141,9 +1121,7 @@ define i1 @icmp_eq_zext_ne_one(i32 %a) { define i1 @icmp_ne_zext_eq_non_boolean(i32 %a) { ; CHECK-LABEL: @icmp_ne_zext_eq_non_boolean( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 2 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[A:%.*]], 0 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp eq i32 %a, 2 @@ -1154,9 +1132,7 @@ define i1 @icmp_ne_zext_eq_non_boolean(i32 %a) { define i1 @icmp_ne_zext_ne_non_boolean(i32 %a) { ; CHECK-LABEL: @icmp_ne_zext_ne_non_boolean( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 2 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[A:%.*]], 1 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp ne i32 %a, 2 @@ -1167,9 +1143,7 @@ define i1 @icmp_ne_zext_ne_non_boolean(i32 %a) { define i1 @icmp_eq_zext_eq_non_boolean(i32 %a) { ; CHECK-LABEL: @icmp_eq_zext_eq_non_boolean( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 2 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[A:%.*]], 0 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp eq i32 %a, 2 @@ -1180,9 +1154,7 @@ define i1 @icmp_eq_zext_eq_non_boolean(i32 %a) { define i1 @icmp_eq_zext_ne_non_boolean(i32 %a) { ; CHECK-LABEL: @icmp_eq_zext_ne_non_boolean( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 2 -; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[A:%.*]], 1 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp ne i32 %a, 2 @@ -1193,10 +1165,7 @@ define i1 @icmp_eq_zext_ne_non_boolean(i32 %a) { define <2 x i1> @icmp_ne_zext_eq_zero_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_zext_eq_zero_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], zeroinitializer -; CHECK-NEXT: [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] -; CHECK-NEXT: ret <2 x i1> [[CMP1]] +; CHECK-NEXT: ret <2 x i1> ; %cmp = icmp eq <2 x i32> %a, %conv = zext <2 x i1> %cmp to <2 x i32> @@ -1206,9 +1175,7 @@ define <2 x i1> @icmp_ne_zext_eq_zero_vec(<2 x i32> %a) { define <2 x i1> @icmp_ne_zext_ne_zero_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_zext_ne_zero_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne <2 x i32> [[A:%.*]], zeroinitializer -; CHECK-NEXT: [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt <2 x i32> [[A:%.*]], ; CHECK-NEXT: ret <2 x i1> [[CMP1]] ; %cmp = icmp ne <2 x i32> %a, @@ -1219,9 +1186,7 @@ define <2 x i1> @icmp_ne_zext_ne_zero_vec(<2 x i32> %a) { define <2 x i1> @icmp_ne_zext_eq_one_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_zext_eq_one_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], -; CHECK-NEXT: [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt <2 x i32> [[A:%.*]], ; CHECK-NEXT: ret <2 x i1> [[CMP1]] ; %cmp = icmp eq <2 x i32> %a, @@ -1232,10 +1197,7 @@ define <2 x i1> @icmp_ne_zext_eq_one_vec(<2 x i32> %a) { define <2 x i1> @icmp_ne_zext_ne_one_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_zext_ne_one_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne <2 x i32> [[A:%.*]], -; CHECK-NEXT: [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] -; CHECK-NEXT: ret <2 x i1> [[CMP1]] +; CHECK-NEXT: ret <2 x i1> ; %cmp = icmp ne <2 x i32> %a, %conv = zext <2 x i1> %cmp to <2 x i32> @@ -1245,9 +1207,7 @@ define <2 x i1> @icmp_ne_zext_ne_one_vec(<2 x i32> %a) { define <2 x i1> @icmp_ne_zext_eq_non_boolean_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_zext_eq_non_boolean_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], -; CHECK-NEXT: [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[A:%.*]], zeroinitializer ; CHECK-NEXT: ret <2 x i1> [[CMP1]] ; %cmp = icmp eq <2 x i32> %a, @@ -1258,10 +1218,7 @@ define <2 x i1> @icmp_ne_zext_eq_non_boolean_vec(<2 x i32> %a) { define i1 @icmp_ne_sext_eq_zero(i32 %a) { ; CHECK-LABEL: @icmp_ne_sext_eq_zero( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 0 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] -; CHECK-NEXT: ret i1 [[CMP1]] +; CHECK-NEXT: ret i1 true ; %cmp = icmp eq i32 %a, 0 %conv = sext i1 %cmp to i32 @@ -1271,9 +1228,8 @@ define i1 @icmp_ne_sext_eq_zero(i32 %a) { define i1 @icmp_ne_sext_ne_zero(i32 %a) { ; CHECK-LABEL: @icmp_ne_sext_ne_zero( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 0 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: [[TMP1:%.*]] = add i32 [[A:%.*]], -1 +; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[TMP1]], -2 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp ne i32 %a, 0 @@ -1284,10 +1240,7 @@ define i1 @icmp_ne_sext_ne_zero(i32 %a) { define i1 @icmp_eq_sext_eq_zero(i32 %a) { ; CHECK-LABEL: @icmp_eq_sext_eq_zero( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 0 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] -; CHECK-NEXT: ret i1 [[CMP1]] +; CHECK-NEXT: ret i1 false ; %cmp = icmp eq i32 %a, 0 %conv = sext i1 %cmp to i32 @@ -1297,9 +1250,8 @@ define i1 @icmp_eq_sext_eq_zero(i32 %a) { define i1 @icmp_eq_sext_ne_zero(i32 %a) { ; CHECK-LABEL: @icmp_eq_sext_ne_zero( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 0 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] +; CHECK-NEXT: [[TMP1:%.*]] = add i32 [[A:%.*]], 1 +; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[TMP1]], 2 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp ne i32 %a, 0 @@ -1310,9 +1262,8 @@ define i1 @icmp_eq_sext_ne_zero(i32 %a) { define i1 @icmp_ne_sext_eq_allones(i32 %a) { ; CHECK-LABEL: @icmp_ne_sext_eq_allones( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], -1 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: [[TMP1:%.*]] = add i32 [[A:%.*]], -1 +; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[TMP1]], -2 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp eq i32 %a, -1 @@ -1323,10 +1274,7 @@ define i1 @icmp_ne_sext_eq_allones(i32 %a) { define i1 @icmp_ne_sext_ne_allones(i32 %a) { ; CHECK-LABEL: @icmp_ne_sext_ne_allones( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], -1 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] -; CHECK-NEXT: ret i1 [[CMP1]] +; CHECK-NEXT: ret i1 true ; %cmp = icmp ne i32 %a, -1 %conv = sext i1 %cmp to i32 @@ -1336,9 +1284,8 @@ define i1 @icmp_ne_sext_ne_allones(i32 %a) { define i1 @icmp_eq_sext_eq_allones(i32 %a) { ; CHECK-LABEL: @icmp_eq_sext_eq_allones( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], -1 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] +; CHECK-NEXT: [[TMP1:%.*]] = add i32 [[A:%.*]], 1 +; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[TMP1]], 2 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp eq i32 %a, -1 @@ -1349,10 +1296,7 @@ define i1 @icmp_eq_sext_eq_allones(i32 %a) { define i1 @icmp_eq_sext_ne_allones(i32 %a) { ; CHECK-LABEL: @icmp_eq_sext_ne_allones( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], -1 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] -; CHECK-NEXT: ret i1 [[CMP1]] +; CHECK-NEXT: ret i1 false ; %cmp = icmp ne i32 %a, -1 %conv = sext i1 %cmp to i32 @@ -1362,9 +1306,7 @@ define i1 @icmp_eq_sext_ne_allones(i32 %a) { define i1 @icmp_ne_sext_eq_otherwise(i32 %a) { ; CHECK-LABEL: @icmp_ne_sext_eq_otherwise( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 2 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[A:%.*]], 0 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp eq i32 %a, 2 @@ -1375,9 +1317,7 @@ define i1 @icmp_ne_sext_eq_otherwise(i32 %a) { define i1 @icmp_ne_sext_ne_otherwise(i32 %a) { ; CHECK-LABEL: @icmp_ne_sext_ne_otherwise( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 2 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[A:%.*]], -1 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp ne i32 %a, 2 @@ -1388,9 +1328,7 @@ define i1 @icmp_ne_sext_ne_otherwise(i32 %a) { define i1 @icmp_eq_sext_eq_otherwise(i32 %a) { ; CHECK-LABEL: @icmp_eq_sext_eq_otherwise( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 2 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[A:%.*]], 0 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp eq i32 %a, 2 @@ -1401,9 +1339,7 @@ define i1 @icmp_eq_sext_eq_otherwise(i32 %a) { define i1 @icmp_eq_sext_ne_otherwise(i32 %a) { ; CHECK-LABEL: @icmp_eq_sext_ne_otherwise( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 2 -; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 -; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp eq i32 [[A:%.*]], -1 ; CHECK-NEXT: ret i1 [[CMP1]] ; %cmp = icmp ne i32 %a, 2 @@ -1414,10 +1350,7 @@ define i1 @icmp_eq_sext_ne_otherwise(i32 %a) { define <2 x i1> @icmp_ne_sext_eq_zero_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_sext_eq_zero_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], zeroinitializer -; CHECK-NEXT: [[CONV:%.*]] = sext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] -; CHECK-NEXT: ret <2 x i1> [[CMP1]] +; CHECK-NEXT: ret <2 x i1> ; %cmp = icmp eq <2 x i32> %a, %conv = sext <2 x i1> %cmp to <2 x i32> @@ -1427,9 +1360,8 @@ define <2 x i1> @icmp_ne_sext_eq_zero_vec(<2 x i32> %a) { define <2 x i1> @icmp_ne_sext_ne_zero_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_sext_ne_zero_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne <2 x i32> [[A:%.*]], zeroinitializer -; CHECK-NEXT: [[CONV:%.*]] = sext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] +; CHECK-NEXT: [[TMP1:%.*]] = add <2 x i32> [[A:%.*]], +; CHECK-NEXT: [[CMP1:%.*]] = icmp ult <2 x i32> [[TMP1]], ; CHECK-NEXT: ret <2 x i1> [[CMP1]] ; %cmp = icmp ne <2 x i32> %a, @@ -1440,9 +1372,8 @@ define <2 x i1> @icmp_ne_sext_ne_zero_vec(<2 x i32> %a) { define <2 x i1> @icmp_ne_sext_eq_allones_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_sext_eq_allones_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], -; CHECK-NEXT: [[CONV:%.*]] = sext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] +; CHECK-NEXT: [[TMP1:%.*]] = add <2 x i32> [[A:%.*]], +; CHECK-NEXT: [[CMP1:%.*]] = icmp ult <2 x i32> [[TMP1]], ; CHECK-NEXT: ret <2 x i1> [[CMP1]] ; %cmp = icmp eq <2 x i32> %a, @@ -1453,10 +1384,7 @@ define <2 x i1> @icmp_ne_sext_eq_allones_vec(<2 x i32> %a) { define <2 x i1> @icmp_ne_sext_ne_allones_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_sext_ne_allones_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp ne <2 x i32> [[A:%.*]], -; CHECK-NEXT: [[CONV:%.*]] = sext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] -; CHECK-NEXT: ret <2 x i1> [[CMP1]] +; CHECK-NEXT: ret <2 x i1> ; %cmp = icmp ne <2 x i32> %a, %conv = sext <2 x i1> %cmp to <2 x i32> @@ -1466,9 +1394,7 @@ define <2 x i1> @icmp_ne_sext_ne_allones_vec(<2 x i32> %a) { define <2 x i1> @icmp_ne_sext_eq_otherwise_vec(<2 x i32> %a) { ; CHECK-LABEL: @icmp_ne_sext_eq_otherwise_vec( -; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], -; CHECK-NEXT: [[CONV:%.*]] = sext <2 x i1> [[CMP]] to <2 x i32> -; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]] +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne <2 x i32> [[A:%.*]], zeroinitializer ; CHECK-NEXT: ret <2 x i1> [[CMP1]] ; %cmp = icmp eq <2 x i32> %a, @@ -1477,6 +1403,108 @@ define <2 x i1> @icmp_ne_sext_eq_otherwise_vec(<2 x i32> %a) { ret <2 x i1> %cmp1 } +define i1 @icmp_ne_sext_ne_zero_i128(i128 %a) { +; CHECK-LABEL: @icmp_ne_sext_ne_zero_i128( +; CHECK-NEXT: [[TMP1:%.*]] = add i128 [[A:%.*]], -1 +; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i128 [[TMP1]], -2 +; CHECK-NEXT: ret i1 [[CMP1]] +; + %cmp = icmp ne i128 %a, 0 + %conv = sext i1 %cmp to i128 + %cmp1 = icmp ne i128 %conv, %a + ret i1 %cmp1 +} + +define i1 @icmp_ne_sext_ne_otherwise_i128(i128 %a) { +; CHECK-LABEL: @icmp_ne_sext_ne_otherwise_i128( +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i128 [[A:%.*]], -1 +; CHECK-NEXT: ret i1 [[CMP1]] +; + %cmp = icmp ne i128 %a, 2 + %conv = sext i1 %cmp to i128 + %cmp1 = icmp ne i128 %conv, %a + ret i1 %cmp1 +} + +; Negative tests with non-equality predicates +define i1 @icmp_ne_sext_sgt_zero_nofold(i32 %a) { +; CHECK-LABEL: @icmp_ne_sext_sgt_zero_nofold( +; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[A:%.*]], 0 +; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: ret i1 [[CMP1]] +; + %cmp = icmp sgt i32 %a, 0 + %conv = sext i1 %cmp to i32 + %cmp1 = icmp ne i32 %conv, %a + ret i1 %cmp1 +} + +define i1 @icmp_slt_sext_ne_zero_nofold(i32 %a) { +; CHECK-LABEL: @icmp_slt_sext_ne_zero_nofold( +; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 0 +; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 +; CHECK-NEXT: [[CMP1:%.*]] = icmp slt i32 [[CONV]], [[A]] +; CHECK-NEXT: ret i1 [[CMP1]] +; + %cmp = icmp ne i32 %a, 0 + %conv = sext i1 %cmp to i32 + %cmp1 = icmp slt i32 %conv, %a + ret i1 %cmp1 +} + +define i1 @icmp_ne_sext_slt_allones_nofold(i32 %a) { +; CHECK-LABEL: @icmp_ne_sext_slt_allones_nofold( +; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[A:%.*]], -1 +; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: ret i1 [[CMP1]] +; + %cmp = icmp slt i32 %a, -1 + %conv = sext i1 %cmp to i32 + %cmp1 = icmp ne i32 %conv, %a + ret i1 %cmp1 +} + +define i1 @icmp_slt_sext_ne_allones_nofold(i32 %a) { +; CHECK-LABEL: @icmp_slt_sext_ne_allones_nofold( +; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], -1 +; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 +; CHECK-NEXT: [[CMP1:%.*]] = icmp slt i32 [[CONV]], [[A]] +; CHECK-NEXT: ret i1 [[CMP1]] +; + %cmp = icmp ne i32 %a, -1 + %conv = sext i1 %cmp to i32 + %cmp1 = icmp slt i32 %conv, %a + ret i1 %cmp1 +} + +define i1 @icmp_ne_sext_slt_otherwise_nofold(i32 %a) { +; CHECK-LABEL: @icmp_ne_sext_slt_otherwise_nofold( +; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[A:%.*]], 2 +; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 +; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]] +; CHECK-NEXT: ret i1 [[CMP1]] +; + %cmp = icmp slt i32 %a, 2 + %conv = sext i1 %cmp to i32 + %cmp1 = icmp ne i32 %conv, %a + ret i1 %cmp1 +} + +define i1 @icmp_slt_sext_ne_otherwise_nofold(i32 %a) { +; CHECK-LABEL: @icmp_slt_sext_ne_otherwise_nofold( +; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 2 +; CHECK-NEXT: [[CONV:%.*]] = sext i1 [[CMP]] to i32 +; CHECK-NEXT: [[CMP1:%.*]] = icmp slt i32 [[CONV]], [[A]] +; CHECK-NEXT: ret i1 [[CMP1]] +; + %cmp = icmp ne i32 %a, 2 + %conv = sext i1 %cmp to i32 + %cmp1 = icmp slt i32 %conv, %a + ret i1 %cmp1 +} + ; tests from PR59555 define i1 @isFloat(i64 %0) { ; CHECK-LABEL: @isFloat(