From af9b00bfd82262b6383d1a1c2aa4f7f0b9f2f23a Mon Sep 17 00:00:00 2001
From: Tobias Gysi <tobias.gysi@nextsilicon.com>
Date: Fri, 30 Aug 2024 19:51:56 +0000
Subject: [PATCH] Address more comments.

---
 mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp  | 4 ++--
 mlir/test/Target/LLVMIR/llvmir-debug.mlir | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
index 4fb2590ce11a71..491dcc7f01e73d 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
@@ -203,7 +203,7 @@ void printExpressionArg(AsmPrinter &printer, uint64_t opcode,
 DIRecursiveTypeAttrInterface
 DICompositeTypeAttr::withRecId(DistinctAttr recId) {
   return DICompositeTypeAttr::get(
-      getContext(), recId, /*isRecSelf=*/false, getTag(), getName(), getFile(),
+      getContext(), recId, getIsRecSelf(), getTag(), getName(), getFile(),
       getLine(), getScope(), getBaseType(), getFlags(), getSizeInBits(),
       getAlignInBits(), getElements(), getDataLocation(), getRank(),
       getAllocated(), getAssociated());
@@ -222,7 +222,7 @@ DICompositeTypeAttr::getRecSelf(DistinctAttr recId) {
 
 DIRecursiveTypeAttrInterface DISubprogramAttr::withRecId(DistinctAttr recId) {
   return DISubprogramAttr::get(
-      getContext(), recId, /*isRecSelf=*/false, getId(), getCompileUnit(),
+      getContext(), recId, getIsRecSelf(), getId(), getCompileUnit(),
       getScope(), getName(), getLinkageName(), getFile(), getLine(),
       getScopeLine(), getSubprogramFlags(), getType(), getRetainedNodes());
 }
diff --git a/mlir/test/Target/LLVMIR/llvmir-debug.mlir b/mlir/test/Target/LLVMIR/llvmir-debug.mlir
index 5eec0afa020fae..07e8648b4d83c5 100644
--- a/mlir/test/Target/LLVMIR/llvmir-debug.mlir
+++ b/mlir/test/Target/LLVMIR/llvmir-debug.mlir
@@ -448,7 +448,7 @@ llvm.func @func_debug_directives() {
 #di_compile_unit = #llvm.di_compile_unit<id = distinct[1]<>, sourceLanguage = DW_LANG_C, file = #di_file, isOptimized = false, emissionKind = None>
 
 // Recursive type itself.
-#di_struct_self = #llvm.di_composite_type<recId = distinct[0]<>, isRecSelf = false>
+#di_struct_self = #llvm.di_composite_type<recId = distinct[0]<>, isRecSelf = true>
 #di_ptr_inner = #llvm.di_derived_type<tag = DW_TAG_pointer_type, baseType = #di_struct_self, sizeInBits = 64>
 #di_subroutine_inner = #llvm.di_subroutine_type<types = #di_null_type, #di_ptr_inner>
 #di_subprogram_inner = #llvm.di_subprogram<