[clang-tidy] Add some tests to 'bugprone-inconsistent-ifelse-braces'

Author: capitan-davide

clang-tools-extra/test/clang-tidy/checkers/bugprone/inconsistent-ifelse-braces-consteval-if.cpp

@@ -1,22 +1,33 @@
 // RUN: %check_clang_tidy -std=c++23-or-later %s bugprone-inconsistent-ifelse-braces %t
 
 bool cond(const char *) { return false; }
+
 void do_something(const char *) {}
 
 // Positive tests.
 void f() {
   if consteval {
     if (cond("if1"))
-      do_something("if-consteval-single-line");
+      do_something("if-single-line");
     else {
     }
     // CHECK-MESSAGES: :[[@LINE-4]]:21: warning: <message> [bugprone-inconsistent-ifelse-braces]
     // CHECK-FIXES: if (cond("if1")) {
     // CHECK-FIXES: } else {
+  }
+
+  if consteval {
+    if (cond("if2"))
+      do_something("if-single-line");
+    else {
+    }
+    // CHECK-MESSAGES: :[[@LINE-4]]:21: warning: <message> [bugprone-inconsistent-ifelse-braces]
+    // CHECK-FIXES: if (cond("if2")) {
+    // CHECK-FIXES: } else {
   } else {
-    if (cond("if1.1")) {
+    if (cond("if2.1")) {
     } else
-      do_something("if-consteval-single-line");
+      do_something("else-single-line");
     // CHECK-MESSAGES: :[[@LINE-2]]:11: warning: <message> [bugprone-inconsistent-ifelse-braces]
     // CHECK-FIXES: } else {
     // CHECK-FIXES: }
@@ -25,4 +36,20 @@ void f() {
 
 // Negative tests.
 void g() {
+  if consteval {
+    if (cond("if0")) {
+      do_something("if-single-line");
+    } else if (cond("if0")) {
+      do_something("elseif-single-line");
+    } else {
+      do_something("else-single-line");
+    }
+  } else {
+    if (cond("if0.1"))
+      do_something("if-single-line");
+    else if (cond("if0.1"))
+      do_something("elseif-single-line");
+    else
+      do_something("else-single-line");
+  }
 }

clang-tools-extra/test/clang-tidy/checkers/bugprone/inconsistent-ifelse-braces.cpp

@@ -1,6 +1,7 @@
 // RUN: %check_clang_tidy %s bugprone-inconsistent-ifelse-braces %t
 
 bool cond(const char *) { return false; }
+
 void do_something(const char *) {}
 
 // Positive tests.
@@ -68,14 +69,14 @@ void f() {
 
   if (cond("if3.2")) {
   } else if (cond("if3.2")) {
-  } else do_something("elseif-same-line");
+  } else do_something("else-same-line");
   // CHECK-MESSAGES: :[[@LINE-1]]:9: warning: <message> [bugprone-inconsistent-ifelse-braces]
-  // CHECK-FIXES: } else { do_something("elseif-same-line");
+  // CHECK-FIXES: } else { do_something("else-same-line");
   // CHECK-FIXES: }
 
   if (cond("if4-outer"))
     if (cond("if4-inner"))
-      do_something("nested-if-single-line");
+      do_something("if-single-line");
     else {
     }
   else {
@@ -88,7 +89,7 @@ void f() {
   // CHECK-FIXES: } else {
 
   if (cond("if5"))
-      do_something("noelse-single-line");
+      do_something("if-single-line");
   else if (cond("if5")) {
   }
   // CHECK-MESSAGES: :[[@LINE-4]]:19: warning: <message> [bugprone-inconsistent-ifelse-braces]
@@ -97,12 +98,26 @@ void f() {
 
   if (cond("if5.1")) {
   } else if (cond("if5.1"))
-      do_something("noelse-single-line");
+      do_something("elseif-single-line");
   // CHECK-MESSAGES: :[[@LINE-2]]:28: warning: <message> [bugprone-inconsistent-ifelse-braces]
   // CHECK-FIXES: } else if (cond("if5.1")) {
   // CHECK-FIXES: }
 }
 
 // Negative tests.
 void g() {
-}
+  if (cond("if0")) {
+    do_something("if-single-line");
+  } else if (cond("if0")) {
+    do_something("elseif-single-line");
+  } else {
+    do_something("else-single-line");
+  }
+
+  if (cond("if1"))
+    do_something("if-single-line");
+  else if (cond("if1"))
+    do_something("elseif-single-line");
+  else
+    do_something("else-single-line");
+}