Skip to content

Commit 145f21c

Browse files
[Github] Make pr-code-format.yml use ci-*-format container (#163044)
This allows us to not spend 60-90s per job installing all of the tools as they are prebuilt into the container.
1 parent 0fc05aa commit 145f21c

File tree

1 file changed

+10
-18
lines changed

1 file changed

+10
-18
lines changed

.github/workflows/pr-code-format.yml

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ on:
1212
jobs:
1313
code_formatter:
1414
runs-on: ubuntu-24.04
15+
container:
16+
image: 'ghcr.io/llvm/ci-ubuntu-24.04-format'
1517
timeout-minutes: 30
1618
concurrency:
1719
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
@@ -23,6 +25,14 @@ jobs:
2325
with:
2426
fetch-depth: 2
2527

28+
# We need to set the repo checkout as safe, otherwise tj-actions/changed-files
29+
# will fail due to the changed ownership inside the container.
30+
# TODO(boomanaiden154): We should probably fix this by having the default user
31+
# in the container have the same ID as the GHA user on the host.
32+
- name: Set Safe Directory
33+
run: |
34+
chown -R root $(pwd)
35+
2636
- name: Get changed files
2737
id: changed-files
2838
uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c # v46.0.5
@@ -39,24 +49,6 @@ jobs:
3949
echo "Formatting files:"
4050
echo "$CHANGED_FILES"
4151
42-
# The clang format version should always be upgraded to the first version
43-
# of a release cycle (x.1.0) or the last version of a release cycle, or
44-
# if there have been relevant clang-format backports.
45-
- name: Install clang-format
46-
uses: aminya/setup-cpp@a276e6e3d1db9160db5edc458e99a30d3b109949 # v1.7.1
47-
with:
48-
clangformat: 21.1.0
49-
50-
- name: Setup Python env
51-
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
52-
with:
53-
python-version: '3.13'
54-
cache: 'pip'
55-
cache-dependency-path: 'llvm/utils/git/requirements_formatting.txt'
56-
57-
- name: Install python dependencies
58-
run: pip install -r llvm/utils/git/requirements_formatting.txt
59-
6052
- name: Run code formatter
6153
env:
6254
GITHUB_PR_NUMBER: ${{ github.event.pull_request.number }}

0 commit comments

Comments
 (0)