Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #4

Open
GN13008 opened this issue Jan 8, 2024 · 3 comments
Open

Dark mode #4

GN13008 opened this issue Jan 8, 2024 · 3 comments

Comments

@GN13008
Copy link
Contributor

GN13008 commented Jan 8, 2024

Hi,

I just forked the project, I think dark mode doesn't work!
Maybe disable it first!

I'd like to work on a mobile app and start open source, so maybe you'll see some PR soon :)

Guillaume.

@llucasspot
Copy link
Owner

Hi Guillaume,

thank you for you contribution, I look forward to work with you and the all community

Can you be more specific with the issue ? The dark mode isn’t working in all the screen, specially those that I forked from @Doelia repo.
I didn’t integrated with my « css » variables.

Dont hesitate to make it work ;) @Doelia and I will be glad to approve PR ;)

Thank you :)

Ps: if needed, an issue concerning DI came back to me, you can see below if you have it : #5

@GN13008
Copy link
Contributor Author

GN13008 commented Jan 8, 2024

Yes sorry for this unspecific issue !
I mean the darkmode works but it's really unreadable on a lot of pages.
Maybe you should disable to start :)

And i am not working with back end yet some problem with my spotify dev account (I think it take some time to activate account)

@llucasspot
Copy link
Owner

Ah yes the colors were badly chosen, it was only to have an implementation.

Strange, I remember that no time was needed, you have juste to well set the URL’s and add an user account.
If you have trouble, don’t hesitate to open issues in the backend repo ;)

https://github.com/llucasspot/boomboom-back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants