[CI] Automate run pre-commit in workflow instead of manual#131
Conversation
yankay
force-pushed
the
fix-enable
branch
3 times, most recently
from
b7e57ec to
35a5617
Compare
|
How do you think about the change :-) |
| shell: bash | ||
|
|
||
| - name: Run pre-commit | ||
| run: pre-commit run --show-diff-on-failure --color=always --verbose --all-files --show-diff-on-failure |
There was a problem hiding this comment.
I'm wondering if we should update the pre-commit-run Make target with the extra flags and call make pre-commit-run here?
Line 47 in 16c25c5
make pre-commit-update?
There was a problem hiding this comment.
Thanks @jgchn
It has been changed . :-)
The function of make pre-commit-update is to update pre-commit hooks, and it will modify the .pre-commit-config file.
…hema.json Signed-off-by: Kay Yan <kay.yan@daocloud.io>
| common: {} | ||
|
|
||
| # -- Usually used when using llm-d-modelservice as a subchart | ||
| enabled: true |
There was a problem hiding this comment.
Can we remove this? This field is mainly used as a condition in chart.yaml whcn as subchart, and by default, this field is set to true in the schema.json
There was a problem hiding this comment.
After communicating with @yankay , considering that the schema json is generated based on values.yaml, it can be left here
3 participants
In #123, a pre-commit error was introduced.
Therefore, this PR modifies the CI workflow to automatically run pre-commit , ref to https://github.com/llm-d-incubation/llm-d-infra/blob/main/.github/workflows/pre-commit.yaml . It also fixes this error by generating schema files during the pre-commit checks.