Skip to content

[llm-d-modelservice] support llm-d-modelservice chart used as a subchart#123

Merged
jgchn merged 3 commits into
llm-d-incubation:mainfrom
JaredTan95:support_enabled
Oct 9, 2025
Merged

[llm-d-modelservice] support llm-d-modelservice chart used as a subchart#123
jgchn merged 3 commits into
llm-d-incubation:mainfrom
JaredTan95:support_enabled

Conversation

@JaredTan95

@JaredTan95 JaredTan95 commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

An exception occurs when using the native helm tool and use llm-d-modelservice as a sub-chart.

The content of Chart.yaml as follows:

dependencies:
  - name: llm-d-modelservice
    version: v0.2.9
    repository: https://llm-d-incubation.github.io/llm-d-modelservice
    condition: llm-d-modelservice.enabled  # 👈 helm decides whether to render resources

and my values.yaml as following:

llm-d-modelservice:
  enabled: false
······
  modelArtifacts:
    uri: "hf://Qwen/Qwen3-0.6B"
    name: "Qwen/Qwen3-0.6B"
    size: 20Gi
······

When I combine the two using helm install ... --set llm-d-modelservice.enabled=true , it doesn't work.

llm-d-modelservice:
- (root): Additional property enabled is not allowed

Looking at other subchart examples .Values.enabled is the proper pattern.

@yankay

yankay commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

Thanks @JaredTan95

It's a good change.
Is it okay to rebase the two commits into one?

@JaredTan95 JaredTan95 force-pushed the support_enabled branch 2 times, most recently from 2bcb887 to 95dcf06 Compare September 28, 2025 04:55
@JaredTan95

Copy link
Copy Markdown
Contributor Author

Thanks @JaredTan95

It's a good change. Is it okay to rebase the two commits into one?

thx, updated

@jgchn jgchn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JaredTan95 thanks for this PR.

Comment thread charts/llm-d-modelservice/values.schema.json
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
@jgchn

jgchn commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

@JaredTan95 Please run make generate to update examples

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
@jgchn jgchn merged commit 16c25c5 into llm-d-incubation:main Oct 9, 2025
3 checks passed
@JaredTan95 JaredTan95 deleted the support_enabled branch October 9, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants