[llm-d-modelservice] support llm-d-modelservice chart used as a subchart#123
Merged
Conversation
53b24f8 to
2e35cc6
Compare
Collaborator
|
Thanks @JaredTan95 It's a good change. |
2bcb887 to
95dcf06
Compare
Contributor
Author
thx, updated |
jgchn
reviewed
Oct 8, 2025
jgchn
left a comment
Collaborator
There was a problem hiding this comment.
Hi @JaredTan95 thanks for this PR.
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
95dcf06 to
83c736c
Compare
Collaborator
|
@JaredTan95 Please run |
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
jgchn
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception occurs when using the native
helmtool and usellm-d-modelserviceas a sub-chart.The content of
Chart.yamlas follows:and my
values.yamlas following:When I combine the two using
helm install ... --set llm-d-modelservice.enabled=true, it doesn't work.Looking at other subchart examples .Values.enabled is the proper pattern.