Skip to content

Commit 02ca358

Browse files
Connormihaljharb
authored andcommitted
[Robustness] stringify: avoid relying on a global undefined (#427)
1 parent 4a17709 commit 02ca358

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/stringify.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ var stringify = function stringify(
118118
var objKeys;
119119
if (generateArrayPrefix === 'comma' && isArray(obj)) {
120120
// we need to join elements in
121-
objKeys = [{ value: obj.length > 0 ? obj.join(',') || null : undefined }];
121+
objKeys = [{ value: obj.length > 0 ? obj.join(',') || null : void undefined }];
122122
} else if (isArray(filter)) {
123123
objKeys = filter;
124124
} else {
@@ -128,7 +128,7 @@ var stringify = function stringify(
128128

129129
for (var j = 0; j < objKeys.length; ++j) {
130130
var key = objKeys[j];
131-
var value = typeof key === 'object' && key.value !== undefined ? key.value : obj[key];
131+
var value = typeof key === 'object' && typeof key.value !== 'undefined' ? key.value : obj[key];
132132

133133
if (skipNulls && value === null) {
134134
continue;
@@ -164,7 +164,7 @@ var normalizeStringifyOptions = function normalizeStringifyOptions(opts) {
164164
return defaults;
165165
}
166166

167-
if (opts.encoder !== null && opts.encoder !== undefined && typeof opts.encoder !== 'function') {
167+
if (opts.encoder !== null && typeof opts.encoder !== 'undefined' && typeof opts.encoder !== 'function') {
168168
throw new TypeError('Encoder has to be a function.');
169169
}
170170

0 commit comments

Comments
 (0)