feat(protocol, decoder, client): enable max_framerate parameter updates #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed runtime restriction on updating max_framerate in StreamParamsUpdateRequest. - Implemented update_params method in TrickleProtocol to allow dynamic updates of max_framerate during operation. - Updated StreamServer to propagate parameter updates to the protocol, improving flexibility in stream management.
- Updated assertions in TestStreamingEndpoints to verify parameter updates without direct comparison of MagicMock objects.
Collaborator
Author
|
Note: the current livepeer-app-pipelines reference app requires |
Contributor
|
I think we tested this together when checking for the limit of encoder. Worked well in that case. LGTM |
JJassonn69
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves an issue with
max_framerateparameter update not being applied during stream start.New functionality is added to allow updating the parameters during runtime
max_framerateinStreamParamsUpdateRequest.update_paramsmethod inTrickleProtocolto allow dynamic updates ofmax_framerateduring operation.StreamServerto propagate parameter updates to the protocol, improving flexibility in stream management.