Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Participant attributes #448

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Participant attributes #448

merged 7 commits into from
Aug 5, 2024

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Jul 29, 2024 •
edited
Loading

JS SDK Reference: livekit/client-sdk-js#1170

  • Notify the diff instead of full attributes
  • Tests

cloudwebrtc
cloudwebrtc approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hiroshihorie hiroshihorie merged commit 937e106 into main Aug 5, 2024
11 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/CLT-466-participant-attributes branch August 5, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroshihorie @cloudwebrtc