Can't put IRC users in config.robot.admins

[saltire]

In CinchPlugin::user_by_nick, when an IRC user is created, their nick is used as the name and a random UUID is used as the id.

User::user_is_admin? checks if the user id is in the config.robot.admins array, which of course it won't be since it's a UUID rather than the nick.

Is there a reason we can't just use the nick as the user id?

[jimmycuadra]

This was essentially a mistake in lita-irc's design. The idea was that the UUID would be the user's unique ID, since on IRC you can change your nickname at any time. That ended up not really making sense, though, since changing your nickname also creates a new UUID with no way to determine that they are the same person.

The quick and dirty fix is to use the UUIDs in config.robot.admins, which is dirty because Lita doesn't expose the UUIDs anywhere and you'd have to connect to Redis directly to fish them out.

The next major version of lita-irc will likely just use nicknames as IDs.