Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RRFC] LitElement theming API #10

Open
aomarks opened this issue Oct 15, 2019 · 6 comments
Open

[RRFC] LitElement theming API #10

aomarks opened this issue Oct 15, 2019 · 6 comments

Comments

@aomarks
Copy link
Member

aomarks commented Oct 15, 2019

The idea is to have a pragmatic API, inspired by https://github.com/vaadin/vaadin-themable-mixin, that makes it possible for component authors to allow consumers to insert custom styling. Related to but not dependent on ::part support/polyfill.

@aomarks aomarks self-assigned this Oct 15, 2019
@aomarks aomarks changed the title Flesh out proposal and POC for LitElement theming API Finish proposal and POC for LitElement theming API Oct 15, 2019
@web-padawan
Copy link

web-padawan commented Oct 15, 2019

Hi! I'm currently working on prototyping Lit versions of our mixins.

You can find a Lit version here:
https://github.com/vaadin/component-mixins/tree/master/packages/themable-element

Note:

  1. dom-module is used for compatibility, so that Lit components can consume styles defined through registerStyle from Polymer

  2. We also sort modules by name to ensure that styles with vaadin- prefix and our theme prefixes come first.

Ping me if you have any ideas you'd like to discuss.

@abdonrd
Copy link

abdonrd commented Nov 14, 2019

@web-padawan
Copy link

@abdonrd thanks, updated my comment above to point to the correct version.

@aomarks aomarks assigned dfreedm and unassigned aomarks Jan 25, 2020
@kevinpschaaf kevinpschaaf transferred this issue from lit/lit-element Sep 8, 2022
@kevinpschaaf kevinpschaaf changed the title Finish proposal and POC for LitElement theming API [lit-element] Finish proposal and POC for LitElement theming API Sep 8, 2022
@justinfagnani
Copy link
Contributor

This is a large enough feature request that it should become an RFC.

@justinfagnani justinfagnani transferred this issue from lit/lit Sep 8, 2022
@justinfagnani justinfagnani changed the title [lit-element] Finish proposal and POC for LitElement theming API [lit-element] LitElement theming API Sep 8, 2022
@augustjk augustjk moved this to 📋 Triaged in Lit Project Board Sep 8, 2022
@justinfagnani
Copy link
Contributor

I moved this from a LitElement issue to an RRFC. I think it'd be good to to also propose an interoperable WCCG Community Protocol proposal too.

@justinfagnani justinfagnani changed the title [lit-element] LitElement theming API [RRFC] LitElement theming API Sep 8, 2022
@gperdomor
Copy link

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Triaged
Development

No branches or pull requests

6 participants