Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add multiple versions of lit resolution section #1261

Merged
merged 8 commits into from
Nov 8, 2023

Conversation

AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented Nov 8, 2023

Fixes: #455

Context

We have a developer warning that warns when multiple versions of Lit have been loaded. This doesn't currently link to documentation that gives clear actionable steps for resolving the warning.

This results in us needing to resolve the issues on a case by case basis via Discord.

Fix

Add a section that discusses the multiple versions of Lit warning, as well as some resolution sections.

Test plan

Docs only change. Can be tested by navigating to:

https://pr1261-1d82c04---lit-dev-5ftespv5na-uc.a.run.app/msg/multiple-versions
https://pr1261-1d82c04---lit-dev-5ftespv5na-uc.a.run.app/docs/tools/requirements/#multiple-lit-versions

Copy link

github-actions bot commented Nov 8, 2023

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1261-1d82c04---lit-dev-5ftespv5na-uc.a.run.app/docs/tools/requirements/#multiple-lit-versions (latest)
https://pr1261-be66c4e---lit-dev-5ftespv5na-uc.a.run.app/

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already discuss this might be better located elsewhere. Perhaps we do this in parallel with #1262

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👯‍♂️

@AndrewJakubowicz AndrewJakubowicz merged commit f922f36 into main Nov 8, 2023
14 of 15 checks passed
@AndrewJakubowicz AndrewJakubowicz deleted the resolving-multiple-bundled-lit branch November 8, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add section to Tools:Requirements about multiple versions
2 participants