Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] showcase example of SSR with VM module #1354

Open
augustjk opened this issue Jul 19, 2024 · 0 comments
Open

[docs] showcase example of SSR with VM module #1354

augustjk opened this issue Jul 19, 2024 · 0 comments

Comments

@augustjk
Copy link
Member

Thanks @KonnorRogers for suggesting!

We can also showcase a running example of SSR with VM module, a la https://stackblitz.com/edit/lit-ssr-vm-module?file=src%2Fserver.js

While making this, I noticed the example in https://lit.dev/docs/ssr/server-usage/#vm-module is different than the example in https://github.com/lit/lit/tree/main/packages/labs/ssr#rendering-in-a-separate-vm-context

They ultimately do the same thing but looks like the lit.dev example was changed in #1026 since renderModule actually creates a module loader with some DOM shim baked into the global which no longer became necessary. (This actually might be some cruft we should address in the SSR package).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant